--===============7381280755514954327== Content-Type: multipart/alternative; boundary="===============8611681835697437151==" --===============8611681835697437151== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Juli 31, 2015, 12:52 nachm., Marco Martin wrote: > > did you test it with left and right edge panels? Didn't notice anything unusual. It also fixes the QueryDialog being shifted to the left corner of the screen if I put the lock_logout applet into a panel and ask it to suspend. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124543/#review83230 ----------------------------------------------------------- On Juli 31, 2015, 8:57 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124543/ > ----------------------------------------------------------- > > (Updated Juli 31, 2015, 8:57 vorm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > When placing an applet on the far right corner of the screen (eg. analog clock), its popup would appear diagonally shifted to the left rather than at the screen edge. > > > Diffs > ----- > > src/plasmaquick/dialog.cpp 6770c1a > > Diff: https://git.reviewboard.kde.org/r/124543/diff/ > > > Testing > ------- > > It no longer does that but I don't know what other implications this voodoo has. On the other hand, the dialogs usually pop out at the top or bottom (for free floating) and this stuff isn't touched, just the horizontal shifting removed. > > > Thanks, > > Kai Uwe Broulik > > --===============8611681835697437151== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124543/

On Juli 31st, 2015, 12:52 nachm. UTC, Marco Martin wrote:

did you test it with left and right edge panels?

Didn't notice anything unusual. It also fixes the QueryDialog being shifted to the left corner of the screen if I put the lock_logout applet into a panel and ask it to suspend.


- Kai Uwe


On Juli 31st, 2015, 8:57 vorm. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.
By Kai Uwe Broulik.

Updated Juli 31, 2015, 8:57 vorm.

Repository: plasma-framework

Description

When placing an applet on the far right corner of the screen (eg. analog clock), its popup would appear diagonally shifted to the left rather than at the screen edge.

Testing

It no longer does that but I don't know what other implications this voodoo has. On the other hand, the dialogs usually pop out at the top or bottom (for free floating) and this stuff isn't touched, just the horizontal shifting removed.

Diffs

  • src/plasmaquick/dialog.cpp (6770c1a)

View Diff

--===============8611681835697437151==-- --===============7381280755514954327== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7381280755514954327==--