'Re: Review Request 124537: RFC: Add autocfg property magic for applet config dialogs'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124537: RFC: Add autocfg property magic for applet config dialogs
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-07-31 19:21:20
Message-ID: 20150731192120.31864.27844 () mimi ! kde ! org
[Download RAW message or body]

--===============4314681971792331041==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Juli 31, 2015, 12:55 nachm., Marco Martin wrote:
> > I like the idea, not sure about the autocfg_ prefix.
> > was it discussed in a bof? are there notes about it?

Yeah, maybe cfgitem or something like that?
Well, they mentioned they need good Kiosk support so I wanted to make the Plasma \
stuff follow that as magically as possible, UI-wise, that is.

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124537/#review83231
-----------------------------------------------------------

On Juli 30, 2015, 8:38 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124537/
> -----------------------------------------------------------
> 
> (Updated Juli 30, 2015, 8:38 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Now you can use autocfg properties to applet config dialogs which are smarter than \
> the cfg stuff we currently have. Instead of binding it directly to a property you \
> bind it to an item and it tries to figure out what to do based on the properties \
> the item has and the type of the config. 
> This allows us to automatically reflect immutables (cf. LiMux) in the UI without \
> further ado by the plasmoid programmer. It can: 
> Boolean config:
> - If it's bound to sth with a "checked" property (eg. checkbox), it sets checked to \
> the config 
> Int config:
> - If it's bound to sth with a "currentIndex" property (eg. combobox), it sets \
>                 currentIndex to the config
> - If it's bound to sth with value, minimumValue and maximumValue property (eg. \
> slider or spinbox) it sets value to the config 
> String config:
> - If it's bound to sth with a "text" property (eg. textfield) it sets text to the \
> config 
> Maybe there's even more? We don't really have introspection so I just rely on \
> properties being there and the programmer not doing rubbish. We could also use the \
> label from the config xml and/or auto-populate min/maxvalue 
> 
> Diffs
> -----
> 
> desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a 
> 
> Diff: https://git.reviewboard.kde.org/r/124537/diff/
> 
> 
> Testing
> -------
> 
> Working pretty nicely
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============4314681971792331041==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124537/">https://git.reviewboard.kde.org/r/124537/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Juli 31st, 2015, 12:55 nachm. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I like the idea, not sure about the autocfg_ prefix. \
was it discussed in a bof? are there notes about it?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, \
maybe cfgitem or something like that? Well, they mentioned they need good Kiosk \
support so I wanted to make the Plasma stuff follow that as magically as possible, \
UI-wise, that is.</p></pre> <br />

<p>- Kai Uwe</p>

<br />
<p>On Juli 30th, 2015, 8:38 nachm. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Juli 30, 2015, 8:38 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now you can use autocfg properties to applet config \
dialogs which are smarter than the cfg stuff we currently have. Instead of binding it \
directly to a property you bind it to an item and it tries to figure out what to do \
based on the properties the item has and the type of the config.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This allows us to automatically reflect immutables (cf. LiMux) in the UI \
without further ado by the plasmoid programmer. It can:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                inherit;">Boolean config:
  - If it's bound to sth with a "checked" property (eg. checkbox), it sets checked to \
the config</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Int config:
  - If it's bound to sth with a "currentIndex" property (eg. combobox), it sets \
                currentIndex to the config
  - If it's bound to sth with value, minimumValue and maximumValue property (eg. \
slider or spinbox) it sets value to the config</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                inherit;">String config:
  - If it's bound to sth with a "text" property (eg. textfield) it sets text to the \
config</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Maybe there's even more? We don't really have \
introspection so I just rely on properties being there and the programmer not doing \
rubbish. We could also use the label from the config xml and/or auto-populate \
min/maxvalue</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Working pretty nicely</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/configuration/AppletConfiguration.qml <span \
style="color: grey">(0302c7a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124537/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4314681971792331041==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 