[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-07-29 23:12:09
Message-ID: 20130729231209.29059.87499 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 29, 2013, 10:58 a.m., Aaron J. Seigo wrote:
> > src/plasma/private/dataengine_p.h, line 37
> > <http://git.reviewboard.kde.org/r/111691/diff/2/?file=174985#file174985line37>
> >
> > see above
Thanks for the review.
I'll merge this branch, and related changes once \
https://git.reviewboard.kde.org/r/111688/ is in kdelibs.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/#review36732
-----------------------------------------------------------
On July 28, 2013, 11:24 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111691/
> -----------------------------------------------------------
>
> (Updated July 28, 2013, 11:24 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> This adds back a ctor that is useful for creating a KPluginFactory, which has the \
> metadata baked into the plugin. With corresponding patches to kdelibs, this allows \
> to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using \
> KService)
>
> Diffs
> -----
>
> src/plasma/dataengine.h d3baad3
> src/plasma/dataengine.cpp a2c68cb
> src/plasma/private/dataengine_p.h d8ade83
>
> Diff: http://git.reviewboard.kde.org/r/111691/diff/
>
>
> Testing
> -------
>
> Build and loaded plugin, verified metadata is completely inside KPluginInfo
>
>
> Thanks,
>
> Sebastian Kügler
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111691/">http://git.reviewboard.kde.org/r/111691/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 29th, 2013, 10:58 a.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111691/diff/2/?file=174985#file174985line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/private/dataengine_p.h</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Plasma</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">37</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">DataEnginePrivate</span><span class="p">(</span><span \
class="n">DataEngine</span> <span class="o">*</span><span class="n">e</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">KPluginInfo</span> \
<span class="o">&</span><span class="n">info</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">37</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">DataEnginePrivate</span><span class="p">(</span><span \
class="n">DataEngine</span> <span class="o">*</span><span class="n">e</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">KPluginInfo</span> \
<span class="o">&</span><span class="n">info</span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QVariantList</span></span><span class="hl"> </span><span class="o"><span \
class="hl">&</span></span><span class="n"><span \
class="hl">args</span></span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QVariantList</span></span><span class="p"><span \
class="hl">()</span>);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for \
the review.
I'll merge this branch, and related changes once \
https://git.reviewboard.kde.org/r/111688/ is in kdelibs.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On July 28th, 2013, 11:24 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated July 28, 2013, 11:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds back a ctor that is useful for creating a KPluginFactory, \
which has the metadata baked into the plugin. With corresponding patches to kdelibs, \
this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. \
without using KService)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build and loaded plugin, verified metadata is completely inside \
KPluginInfo</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/dataengine.h <span style="color: grey">(d3baad3)</span></li>
<li>src/plasma/dataengine.cpp <span style="color: grey">(a2c68cb)</span></li>
<li>src/plasma/private/dataengine_p.h <span style="color: \
grey">(d8ade83)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111691/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic