This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111691/

On July 29th, 2013, 10:58 a.m. UTC, Aaron J. Seigo wrote:

src/plasma/private/dataengine_p.h (Diff revision 2)
namespace Plasma
37
        DataEnginePrivate(DataEngine *e, const KPluginInfo &info);
37
        DataEnginePrivate(DataEngine *e, const KPluginInfo &info, const QVariantList &args = QVariantList());
see above
Thanks for the review.

I'll merge this branch, and related changes once https://git.reviewboard.kde.org/r/111688/ is in kdelibs.

- Sebastian


On July 28th, 2013, 11:24 p.m. UTC, Sebastian Kügler wrote:

Review request for Plasma and Aaron J. Seigo.
By Sebastian Kügler.

Updated July 28, 2013, 11:24 p.m.

Description

This adds back a ctor that is useful for creating a KPluginFactory, which has the metadata baked into the plugin. With corresponding patches to kdelibs, this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using KService)

Testing

Build and loaded plugin, verified metadata is completely inside KPluginInfo

Diffs

  • src/plasma/dataengine.h (d3baad3)
  • src/plasma/dataengine.cpp (a2c68cb)
  • src/plasma/private/dataengine_p.h (d8ade83)

View Diff