'Re: Review Request 111618: Fix launcher regression, only show icons instead of icons + text'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111618: Fix launcher regression, only show icons instead of icons + text
From:       "Mark Gaiser" <markg85 () gmail ! com>
Date:       2013-07-29 21:25:12
Message-ID: 20130729212512.713.31207 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111618/
-----------------------------------------------------------

(Updated July 29, 2013, 9:25 p.m.)

Status
------

This change has been discarded.

Review request for Plasma and Eike Hein.

Description
-------

As described in the bug report, the launcher regressed with the move to the QML based \
tasks. I did my best to correct the launcher regression. The attachment shows how the \
launchers look with this patch.

This addresses bug 321128.
    http://bugs.kde.org/show_bug.cgi?id=321128

Diffs
-----

  plasma/desktop/applets/tasks/package/contents/code/layout.js cb7a1c2 
  plasma/desktop/applets/tasks/package/contents/ui/Task.qml 70267fb 

Diff: http://git.reviewboard.kde.org/r/111618/diff/

Testing
-------

Tested it and works just like it used to work in KDE 4.10.

File Attachments
----------------

  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/20/fix_launcher.png

Thanks,

Mark Gaiser

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111618/">http://git.reviewboard.kde.org/r/111618/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Eike Hein.</div>
<div>By Mark Gaiser.</div>

<p style="color: grey;"><i>Updated July 29, 2013, 9:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As described in the bug report, the launcher regressed with the move to \
the QML based tasks. I did my best to correct the launcher regression. The attachment \
shows how the launchers look with this patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it and works just like it used to work in KDE 4.10.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=321128">321128</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/tasks/package/contents/code/layout.js <span style="color: \
grey">(cb7a1c2)</span></li>

 <li>plasma/desktop/applets/tasks/package/contents/ui/Task.qml <span style="color: \
grey">(70267fb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111618/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/20/fix_launcher.png">fix_launcher.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 