'Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111691: Add KPluginFactory compatible ctor to dataengine
From:       "Commit Hook" <null () kde ! org>
Date:       2013-08-05 16:41:09
Message-ID: 20130805164109.31831.53021 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111691/#review37144
-----------------------------------------------------------

This review has been submitted with commit 0368d7423c98c1b9ffcacc16b28dec415d76e8d5 \
by Sebastian Kügler to branch master.

- Commit Hook

On July 28, 2013, 11:24 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111691/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 11:24 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> This adds back a ctor that is useful for creating a KPluginFactory, which has the \
> metadata baked into the plugin. With corresponding patches to kdelibs, this allows \
> to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. without using \
> KService) 
> 
> Diffs
> -----
> 
> src/plasma/dataengine.h d3baad3 
> src/plasma/dataengine.cpp a2c68cb 
> src/plasma/private/dataengine_p.h d8ade83 
> 
> Diff: http://git.reviewboard.kde.org/r/111691/diff/
> 
> 
> Testing
> -------
> 
> Build and loaded plugin, verified metadata is completely inside KPluginInfo
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111691/">http://git.reviewboard.kde.org/r/111691/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0368d7423c98c1b9ffcacc16b28dec415d76e8d5 by Sebastian Kügler \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 28th, 2013, 11:24 p.m. UTC, Sebastian Kügler wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated July 28, 2013, 11:24 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds back a ctor that is useful for creating a KPluginFactory, \
which has the metadata baked into the plugin. With corresponding patches to kdelibs, \
this allows to create a dataengine, with valid KPluginInfo from a Qt plugin (i.e. \
without using KService)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build and loaded plugin, verified metadata is completely inside \
KPluginInfo</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/dataengine.h <span style="color: grey">(d3baad3)</span></li>

 <li>src/plasma/dataengine.cpp <span style="color: grey">(a2c68cb)</span></li>

 <li>src/plasma/private/dataengine_p.h <span style="color: \
grey">(d8ade83)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111691/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 