'Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area
From:       "Reza Shah" <rshah0385 () kireihana ! com>
Date:       2012-06-29 11:38:40
Message-ID: 20120629113840.26255.61397 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105340/
-----------------------------------------------------------

(Updated June 29, 2012, 11:38 a.m.)

Review request for Plasma and Marco Martin.

Changes
-------

changed to close activity manager only

Description
-------

There is a bug which prevent widget explorer or activity manager not closed=
 when clicking desktop area above panel.

Steps to reproduce:
- after login and with no window appear (we can see desktop area clearly).
- open widget explorer from panel
- then click at desktop area somewhere above the panel.

The expected result is widget explorer or activity manager will be closed.

Diffs (updated)
-----

  plasma/desktop/shell/controllerwindow.cpp 306a152 =

Diff: http://git.reviewboard.kde.org/r/105340/diff/

Testing
-------

test against master branch.

Thanks,

Reza Shah

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105340/">http://git.reviewboard.kde.org/r/105340/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Reza Shah.</div>

<p style="color: grey;"><i>Updated June 29, 2012, 11:38 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">changed to close activity manager only</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is a bug which prevent widget explorer or activity manager not \
closed when clicking desktop area above panel.

Steps to reproduce:
- after login and with no window appear (we can see desktop area clearly).
- open widget explorer from panel
- then click at desktop area somewhere above the panel.

The expected result is widget explorer or activity manager will be closed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">test against master branch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/controllerwindow.cpp <span style="color: \
grey">(306a152)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105340/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 