From kde-panel-devel Fri Jun 29 11:38:40 2012 From: "Reza Shah" Date: Fri, 29 Jun 2012 11:38:40 +0000 To: kde-panel-devel Subject: Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area Message-Id: <20120629113840.26255.61397 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134097015522320 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8033765403484017767==" --===============8033765403484017767== Content-Type: multipart/alternative; boundary="===============4020228197941413189==" --===============4020228197941413189== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105340/ ----------------------------------------------------------- (Updated June 29, 2012, 11:38 a.m.) Review request for Plasma and Marco Martin. Changes ------- changed to close activity manager only Description ------- There is a bug which prevent widget explorer or activity manager not closed= when clicking desktop area above panel. Steps to reproduce: - after login and with no window appear (we can see desktop area clearly). - open widget explorer from panel - then click at desktop area somewhere above the panel. The expected result is widget explorer or activity manager will be closed. Diffs (updated) ----- plasma/desktop/shell/controllerwindow.cpp 306a152 = Diff: http://git.reviewboard.kde.org/r/105340/diff/ Testing ------- test against master branch. Thanks, Reza Shah --===============4020228197941413189== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105340/

Review request for Plasma and Marco Martin.
By Reza Shah.

Updated June 29, 2012, 11:38 a.m.

Changes 
changed to close activity manager only

Descripti= on 

There is a bug which prevent widget explorer or activity man=
ager not closed when clicking desktop area above panel.

Steps to reproduce:
- after login and with no window appear (we can see desktop area clearly).
- open widget explorer from panel
- then click at desktop area somewhere above the panel.

The expected result is widget explorer or activity manager will be closed.<=
/pre>

Testing <= /h1> 
test against master branch.

Diffs= (updated)

  • plasma/desktop/shell/controllerwindow.cpp = (306a152)

View Diff
--===============4020228197941413189==-- --===============8033765403484017767== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8033765403484017767==--