'Re: Review Request: Fix the minimum size of some applets'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix the minimum size of some applets
From:       "Maarten De Meyer" <de.meyer.maarten () gmail ! com>
Date:       2012-06-29 11:13:41
Message-ID: 20120629111341.17796.16893 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/
-----------------------------------------------------------

(Updated June 29, 2012, 11:13 a.m.)

Review request for Plasma.

Changes
-------

New diff

Description
-------

This fixes the minimum size of the following applets: showdashboard, system=
loadviewer, pastebin, weatherstation and timer.
Some sizes were to small, so there were visual glitches and some applets ha=
d no minimum value set.

I have no commit rights.

Diffs (updated)
-----

  applets/pastebin/pastebin.cpp 208e6a3 =

  applets/showdashboard/showdashboard.h 695347f =

  applets/showdashboard/showdashboard.cpp 1c2f623 =

  applets/systemloadviewer/systemloadviewer.cpp b852256 =

  applets/timer/timer.cpp ba5ee66 =

  applets/weatherstation/weatherstation.h 6d4ae24 =

  applets/weatherstation/weatherstation.cpp 8ada9c2 =

Diff: http://git.reviewboard.kde.org/r/105234/diff/

Testing
-------

Run the applets with their new minimum size, and minimized.

Thanks,

Maarten De Meyer

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105234/">http://git.reviewboard.kde.org/r/105234/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Maarten De Meyer.</div>

<p style="color: grey;"><i>Updated June 29, 2012, 11:13 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New diff</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the minimum size of the following applets: showdashboard, \
systemloadviewer, pastebin, weatherstation and timer. Some sizes were to small, so \
there were visual glitches and some applets had no minimum value set.

I have no commit rights.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run the applets with their new minimum size, and minimized.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/pastebin/pastebin.cpp <span style="color: grey">(208e6a3)</span></li>

 <li>applets/showdashboard/showdashboard.h <span style="color: \
grey">(695347f)</span></li>

 <li>applets/showdashboard/showdashboard.cpp <span style="color: \
grey">(1c2f623)</span></li>

 <li>applets/systemloadviewer/systemloadviewer.cpp <span style="color: \
grey">(b852256)</span></li>

 <li>applets/timer/timer.cpp <span style="color: grey">(ba5ee66)</span></li>

 <li>applets/weatherstation/weatherstation.h <span style="color: \
grey">(6d4ae24)</span></li>

 <li>applets/weatherstation/weatherstation.cpp <span style="color: \
grey">(8ada9c2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105234/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 