'Re: Review Request: Plasmate:void ProjectManager::removeDirectory'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate:void ProjectManager::removeDirectory
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2011-07-24 20:45:03
Message-ID: 20110724204503.3209.4370 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
-----------------------------------------------------------

(Updated July 24, 2011, 8:45 p.m.)

Review request for Plasma.

Changes
-------

changes:now the user is able to remove also projects that are not being gen=
erated by the plasmate

Summary
-------

Hello,

the method removeDirectory wasn't removing the parent folder. =

For example,if we named out plasmoid my_plasmoid it would have a directory =
like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_=
plasmoid" and the after calling the removeDirectory(before the patch) metho=
d we would have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.

Diffs (updated)
-----

  mainwindow.cpp 3dbdefc =

  projectmanager/projectmanager.h 53ef226 =

  projectmanager/projectmanager.cpp 122e48d =

Diff: http://git.reviewboard.kde.org/r/101550/diff

Testing
-------

compiles without issues and without regressions.

Thanks,

Giorgos

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101550/">http://git.reviewboard.kde.org/r/101550/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated July 24, 2011, 8:45 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">changes:now the user is able to remove also projects that are not being \
generated by the plasmate</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

the method removeDirectory wasn&#39;t removing the parent folder. 
For example,if we named out plasmoid my_plasmoid it would have a directory like this \
&quot;$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid&quot; \
and the after calling the removeDirectory(before the patch) method we would have a \
directory like this: &quot;&quot;$(kde4-config \
--localprefix)/share/apps/plasmate/my_plasmoid/NOTES&quot;. With the patch the entire \
folder my_plasmoid is being deleted.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles without issues and without regressions.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.cpp <span style="color: grey">(3dbdefc)</span></li>

 <li>projectmanager/projectmanager.h <span style="color: grey">(53ef226)</span></li>

 <li>projectmanager/projectmanager.cpp <span style="color: \
grey">(122e48d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101550/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 