--===============0041858088==
Content-Type: multipart/alternative;
boundary="===============5461557374124290271=="
--===============5461557374124290271==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/
-----------------------------------------------------------
(Updated July 24, 2011, 8:45 p.m.)
Review request for Plasma.
Changes
-------
changes:now the user is able to remove also projects that are not being gen=
erated by the plasmate
Summary
-------
Hello,
the method removeDirectory wasn't removing the parent folder. =
For example,if we named out plasmoid my_plasmoid it would have a directory =
like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_=
plasmoid" and the after calling the removeDirectory(before the patch) metho=
d we would have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
With the patch the entire folder my_plasmoid is being deleted.
Diffs (updated)
-----
mainwindow.cpp 3dbdefc =
projectmanager/projectmanager.h 53ef226 =
projectmanager/projectmanager.cpp 122e48d =
Diff: http://git.reviewboard.kde.org/r/101550/diff
Testing
-------
compiles without issues and without regressions.
Thanks,
Giorgos
--===============5461557374124290271==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Review request for Plasma.
By Giorgos Tsiapaliwkas.
Updated July 24, 2011, 8:45 p.m.
Changes=
h1>
changes:now the user is able to remove also projects that ar=
e not being generated by the plasmate
|
Descripti=
on
Hello,
the method removeDirectory wasn't removing the parent folder. =
For example,if we named out plasmoid my_plasmoid it would have a directory =
like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoi=
d/my_plasmoid" and the after calling the removeDirectory(before the pa=
tch) method we would have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NO=
TES".
With the patch the entire folder my_plasmoid is being deleted.
|
Testing <=
/h1>
compiles without issues and without regressions.
|
Diffs=
(updated)
- mainwindow.cpp (3dbdefc)
- projectmanager/projectmanager.h (53ef226)<=
/span>
- projectmanager/projectmanager.cpp (122e48d=
)
View Diff
|
--===============5461557374124290271==--
--===============0041858088==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--===============0041858088==--