From kde-panel-devel Sun Jul 24 20:45:03 2011 From: "Giorgos Tsiapaliwkas" Date: Sun, 24 Jul 2011 20:45:03 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate:void ProjectManager::removeDirectory Message-Id: <20110724204503.3209.4370 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131154034922530 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0041858088==" --===============0041858088== Content-Type: multipart/alternative; boundary="===============5461557374124290271==" --===============5461557374124290271== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/ ----------------------------------------------------------- (Updated July 24, 2011, 8:45 p.m.) Review request for Plasma. Changes ------- changes:now the user is able to remove also projects that are not being gen= erated by the plasmate Summary ------- Hello, the method removeDirectory wasn't removing the parent folder. = For example,if we named out plasmoid my_plasmoid it would have a directory = like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_= plasmoid" and the after calling the removeDirectory(before the patch) metho= d we would have a directory like this: ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES". With the patch the entire folder my_plasmoid is being deleted. Diffs (updated) ----- mainwindow.cpp 3dbdefc = projectmanager/projectmanager.h 53ef226 = projectmanager/projectmanager.cpp 122e48d = Diff: http://git.reviewboard.kde.org/r/101550/diff Testing ------- compiles without issues and without regressions. Thanks, Giorgos --===============5461557374124290271== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101550/

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated July 24, 2011, 8:45 p.m.

Changes 
changes:now the user is able to remove also projects that ar=
e not being generated by the plasmate

Descripti= on 

Hello,

the method removeDirectory wasn't removing the parent folder. =

For example,if we named out plasmoid my_plasmoid it would have a directory =
like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoi=
d/my_plasmoid" and the after calling the removeDirectory(before the pa=
tch) method we would have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NO=
TES".
With the patch the entire folder my_plasmoid is being deleted.

Testing <= /h1> 
compiles without issues and without regressions.

Diffs= (updated)

  • mainwindow.cpp (3dbdefc)
  • projectmanager/projectmanager.h (53ef226)<= /span>
  • projectmanager/projectmanager.cpp (122e48d= )

View Diff
--===============5461557374124290271==-- --===============0041858088== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0041858088==--