[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:void ProjectManager::removeDirectory
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-07-22 8:28:12
Message-ID: 20110722082812.18384.17443 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 19, 2011, 10:50 p.m., Aaron J. Seigo wrote:
> > projectmanager/projectmanager.cpp, lines 107-109
> > <http://git.reviewboard.kde.org/r/101550/diff/3/?file=27486#file27486line107>
> >
> > so now it will _only_ delete local projects?
> >
> > or even worse: if you have a project with the same name as a local project, it \
> > will delete the local one.
> > what should be done is to see if the project _is_ a local project (e.g. the \
> > project starts with KStandardDirs::locateLocal("appdata", "/")) and if so do not \
> > do the cd("..") in deleteProject.
>
> Giorgos Tsiapaliwkas wrote:
> So,you want plasmate to delete also projects that are not local(~/.kde4)?
> Yes if the project is not a local one,the cd("..") is useless.Also plasmate has to \
> check if a project is local or not,before it does "const QString project = \
> KStandardDirs::locateLocal("appdata",recentProject + "/");".correct?
yes, i think it should be up to the user to delete whatever they wish :)
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4878
-----------------------------------------------------------
On July 19, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> -----------------------------------------------------------
>
> (Updated July 19, 2011, 11 a.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Hello,
>
> the method removeDirectory wasn't removing the parent folder.
> For example,if we named out plasmoid my_plasmoid it would have a directory like \
> this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and \
> the after calling the removeDirectory(before the patch) method we would have a \
> directory like this: ""$(kde4-config \
> --localprefix)/share/apps/plasmate/my_plasmoid/NOTES". With the patch the entire \
> folder my_plasmoid is being deleted.
>
> Diffs
> -----
>
> mainwindow.cpp e08581f
> projectmanager/projectmanager.h 53ef226
> projectmanager/projectmanager.cpp 122e48d
>
> Diff: http://git.reviewboard.kde.org/r/101550/diff
>
>
> Testing
> -------
>
> compiles without issues and without regressions.
>
>
> Thanks,
>
> Giorgos
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101550/">http://git.reviewboard.kde.org/r/101550/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 19th, 2011, 10:50 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101550/diff/3/?file=27486#file27486line107" \
style="color: black; font-weight: bold; text-decoration: \
underline;">projectmanager/projectmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ProjectManager::confirmRemoveFromDisk()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">107</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">QString</span> <span class="n">project</span> \
<span class="o">=</span> <span class="n">KStandardDirs</span><span \
class="o">::</span><span class="n">locateLocal</span><span class="p">(</span><span \
class="s">"appdata"</span><span class="p">,</span><span \
class="n">recentProject</span> <span class="o">+</span> <span \
class="s">"/"</span><span class="p">);</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">105</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">108</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">106</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">deleteFromDisk</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">109</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">deleteFromDisk</span><span class="hl"> </span><span \
class="o"><span class="hl">&&</span></span><span class="hl"> </span><span \
class="o"><span class="hl">!</span></span><span class="n"><span \
class="hl">project</span></span><span class="p"><span class="hl">.</span></span><span \
class="n"><span class="hl">isEmpty</span></span><span class="p"><span \
class="hl">()</span>)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so now it will _only_ \
delete local projects?
or even worse: if you have a project with the same name as a local project, it will \
delete the local one.
what should be done is to see if the project _is_ a local project (e.g. the project \
starts with KStandardDirs::locateLocal("appdata", "/")) and if so \
do not do the cd("..") in deleteProject.</pre> </blockquote>
<p>On July 20th, 2011, 9:01 a.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So,you want plasmate to \
delete also projects that are not local(~/.kde4)? Yes if the project is not a local \
one,the cd("..") is useless.Also plasmate has to check if a project is \
local or not,before it does "const QString project = \
KStandardDirs::locateLocal("appdata",recentProject + \
"/");".correct?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, i \
think it should be up to the user to delete whatever they wish :)</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On July 19th, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated July 19, 2011, 11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
the method removeDirectory wasn't removing the parent folder.
For example,if we named out plasmoid my_plasmoid it would have a directory like this \
"$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" \
and the after calling the removeDirectory(before the patch) method we would have a \
directory like this: ""$(kde4-config \
--localprefix)/share/apps/plasmate/my_plasmoid/NOTES". With the patch the entire \
folder my_plasmoid is being deleted.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles without issues and without regressions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(e08581f)</span></li>
<li>projectmanager/projectmanager.h <span style="color: grey">(53ef226)</span></li>
<li>projectmanager/projectmanager.cpp <span style="color: \
grey">(122e48d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101550/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic