[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Use Plasma::ScrollWidget in the widget explorer
From: "Anselmo Melo" <anselmolsm () gmail ! com>
Date: 2010-09-27 10:44:41
Message-ID: 20100927104441.26193.52057 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-24 10:43:08, Beat Wolf wrote:
> > what is the status of this patch?
> =
> Aur=C3=A9lien G=C3=A2teau wrote:
> I need to ping someone so that it gets reviewed.
I like this idea because it cleans the interface, specially in the vertical=
orientation.
The patch need to be updated due to recent changes in widgetexplorer.cpp, t=
hough. =
- Anselmo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4676/#review7753
-----------------------------------------------------------
On 2010-08-04 21:02:11, Aur=C3=A9lien G=C3=A2teau wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4676/
> -----------------------------------------------------------
> =
> (Updated 2010-08-04 21:02:11)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on=
plasma-devel.
> =
> The horizontal orientation behaved a bit strangely: AbstractIconList was =
becoming much larger than the screen width. I had to change the layout code=
to include the "Close" button inside FilteringWidget layout instead of cre=
ating another layout.
> =
> Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar=
slider sizes.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h =
1147944 =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cp=
p 1147944 =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app=
letsfiltering.h 1147944 =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app=
letsfiltering.cpp 1147944 =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app=
letslist.h 1147944 =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app=
letslist.cpp 1147944 =
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/wid=
getexplorer.cpp 1147944 =
> =
> Diff: http://svn.reviewboard.kde.org/r/4676/diff
> =
> =
> Testing
> -------
> =
> Tested in both horizontal and vertical modes, with lists larger and small=
er than the view.
> =
> =
> Thanks,
> =
> Aur=C3=A9lien
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4676/">http://svn.reviewboard.kde.org/r/4676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 24th, 2010, 10:43 a.m., <b>Beat \
Wolf</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">what is the status of this patch?</pre> </blockquote>
<p>On September 24th, 2010, 8:35 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need to ping someone \
so that it gets reviewed.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like this idea because \
it cleans the interface, specially in the vertical orientation. The patch need to be \
updated due to recent changes in widgetexplorer.cpp, though. </pre> <br />
<p>- Anselmo</p>
<br />
<p>On August 4th, 2010, 9:02 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-08-04 21:02:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed \
on plasma-devel.
The horizontal orientation behaved a bit strangely: AbstractIconList was becoming \
much larger than the screen width. I had to change the layout code to include the \
"Close" button inside FilteringWidget layout instead of creating another \
layout.
Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider \
sizes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in both horizontal and vertical modes, with lists larger and \
smaller than the view.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h <span \
style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp <span \
style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp \
<span style="color: grey">(1147944)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4676/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic