On September 24th, 2010, 10:43 a.m., Beat Wolf wrote:
what is the status of this patch?
On September 24th, 2010, 8:35 p.m., Aurélien Gâteau wrote:
I need to ping someone so that it gets reviewed.
I like this idea because it cleans the interface, specially in the vertical orientation.
The patch need to be updated due to recent changes in widgetexplorer.cpp, though.
- Anselmo
On August 4th, 2010, 9:02 p.m., Aurélien Gâteau wrote:
|
Review request for Plasma.
By Aurélien Gâteau.
Updated 2010-08-04 21:02:11
Description
Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on plasma-devel.
The horizontal orientation behaved a bit strangely: AbstractIconList was becoming much larger than the screen width. I had to change the layout code to include the "Close" button inside FilteringWidget layout instead of creating another layout.
Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider sizes.
|
Testing
Tested in both horizontal and vertical modes, with lists larger and smaller than the view.
|
Diffs
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h (1147944)
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp (1147944)
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h (1147944)
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp (1147944)
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h (1147944)
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp (1147944)
- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp (1147944)
View Diff
|