From kde-panel-devel Mon Sep 27 10:44:41 2010 From: "Anselmo Melo" Date: Mon, 27 Sep 2010 10:44:41 +0000 To: kde-panel-devel Subject: Re: Review Request: Use Plasma::ScrollWidget in the widget explorer Message-Id: <20100927104441.26193.52057 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=128558431728044 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1211492210==" --===============1211492210== Content-Type: multipart/alternative; boundary="===============0862517187576557024==" --===============0862517187576557024== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-09-24 10:43:08, Beat Wolf wrote: > > what is the status of this patch? > = > Aur=C3=A9lien G=C3=A2teau wrote: > I need to ping someone so that it gets reviewed. I like this idea because it cleans the interface, specially in the vertical= orientation. The patch need to be updated due to recent changes in widgetexplorer.cpp, t= hough. = - Anselmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4676/#review7753 ----------------------------------------------------------- On 2010-08-04 21:02:11, Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4676/ > ----------------------------------------------------------- > = > (Updated 2010-08-04 21:02:11) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on= plasma-devel. > = > The horizontal orientation behaved a bit strangely: AbstractIconList was = becoming much larger than the screen width. I had to change the layout code= to include the "Close" button inside FilteringWidget layout instead of cre= ating another layout. > = > Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar= slider sizes. > = > = > Diffs > ----- > = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h = 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cp= p 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app= letsfiltering.h 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app= letsfiltering.cpp 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app= letslist.h 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/app= letslist.cpp 1147944 = > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/wid= getexplorer.cpp 1147944 = > = > Diff: http://svn.reviewboard.kde.org/r/4676/diff > = > = > Testing > ------- > = > Tested in both horizontal and vertical modes, with lists larger and small= er than the view. > = > = > Thanks, > = > Aur=C3=A9lien > = > --===============0862517187576557024== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/4676/

On September 24th, 2010, 10:43 a.m., Beat W= olf wrote:

what is t=
he status of this patch?

On September 24th, 2010, 8:35 p.m., Aur=C3=A9lien G=C3=A2teau wr= ote:

I need to=
 ping someone so that it gets reviewed.
I like this=
 idea because it cleans the interface, specially in the vertical orientatio=
n.
The patch need to be updated due to recent changes in widgetexplorer.cpp, t=
hough.

- Anselmo


On August 4th, 2010, 9:02 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma.
By Aur=C3=A9lien G=C3=A2teau.

Updated 2010-08-04 21:02:11

Descripti= on 

Make AbstractIconList inherit from Plasma::ScrollWidget, has=
 discussed on plasma-devel.

The horizontal orientation behaved a bit strangely: AbstractIconList was be=
coming much larger than the screen width. I had to change the layout code t=
o include the "Close" button inside FilteringWidget layout instea=
d of creating another layout.

Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar s=
lider sizes.

Testing <= /h1> 
Tested in both horizontal and vertical modes, with lists lar=
ger and smaller than the view.

Diffs=

  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h= (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.c= pp (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap= pletsfiltering.h (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap= pletsfiltering.cpp (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap= pletslist.h (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap= pletslist.cpp (1147944)
  • trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/wi= dgetexplorer.cpp (1147944)

View Diff
--===============0862517187576557024==-- --===============1211492210== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1211492210==--