'Review Request: Do not use tree view for categories in the vertical'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Do not use tree view for categories in the vertical
From:       "Anselmo Melo" <anselmolsm () gmail ! com>
Date:       2010-09-27 10:57:34
Message-ID: 20100927105734.26412.1914 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5446/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

The propose here is to remove the Tree View used in the widgets explorer in=
 vertical orientation. In its place, use the same button of the horizontal =
orientation, what simplifies the code (removes a class and some checks) and=
 improves the use of space as the widgets list can grow vertically.

Better if combined with http://reviewboard.kde.org/r/4676/ as we also gain =
the space currently occupied by the arrow buttons and the close button in t=
he bottom left corner.

The screenshots attached show the current widget explorer with the categori=
es tree view and the proposed one, using the categories button.

Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appl=
etsfiltering.h 1179288 =

  /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appl=
etsfiltering.cpp 1179288 =

Diff: http://svn.reviewboard.kde.org/r/5446/diff

Testing
-------

Tested in both horizontal and vertical orientations.

Screenshots
-----------

current widgets explorer
  http://svn.reviewboard.kde.org/r/5446/s/511/
proposed, not using the tree view
  http://svn.reviewboard.kde.org/r/5446/s/512/

Thanks,

Anselmo

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5446/">http://svn.reviewboard.kde.org/r/5446/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anselmo Melo.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The propose here is to remove the Tree View used in the widgets explorer \
in vertical orientation. In its place, use the same button of the horizontal \
orientation, what simplifies the code (removes a class and some checks) and improves \
the use of space as the widgets list can grow vertically.

Better if combined with http://reviewboard.kde.org/r/4676/ as we also gain the space \
currently occupied by the arrow buttons and the close button in the bottom left \
corner.

The screenshots attached show the current widget explorer with the categories tree \
view and the proposed one, using the categories button.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in both horizontal and vertical orientations.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h \
<span style="color: grey">(1179288)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp \
<span style="color: grey">(1179288)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5446/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/5446/s/511/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/25/widgetexplorer-current_400x100.png" \
style="border: 1px black solid;" alt="current widgets explorer" /></a>

 <a href="http://svn.reviewboard.kde.org/r/5446/s/512/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/25/widgetexplorer-proposed_400x100.png" \
style="border: 1px black solid;" alt="proposed, not using the tree view" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 