[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Game of Life Plasmoid -- Cleanup and
From: the.goofeedude () gmail ! com
Date: 2010-08-23 19:12:21
Message-ID: 20100823191221.21969.60466 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5027/
-----------------------------------------------------------
(Updated 2010-08-23 19:12:21.184543)
Review request for Plasma.
Changes
-------
The updated diff is built on top of the bugfix which was submitted as 11668=
19 in trunk (http://reviewboard.kde.org/r/5055/)
Also included in the updated diff are member variable renamings (prepending=
m_ to member variable names.)
Summary (updated)
-------
Update (8/23/10): The patch adds two new features to the life applet: game =
board reflection (the user can choose to generate initial populations that =
are symmetrical about the horizontal and/or vertical axes,) and user-config=
urable population density (the user can choose what approximate percentage =
of cells will be alive in the initial population.)
With the addition of the new configuration options, the configuration UI wa=
s also updated so that using tab to scroll through options would be consist=
ent (top to bottom.)
This submit also includes member variable renamings (prepending m_ to membe=
r variable names.)
Diffs (updated)
-----
/trunk/KDE/kdeplasma-addons/applets/life/life.h 1166777 =
/trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1167084 =
/trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui 1166777 =
Diff: http://reviewboard.kde.org/r/5027/diff
Testing
-------
Various game board sizes were tested (odd and even heights and widths, squa=
re and non-square.) The configuration dialog was opened several times and t=
ested to confirm tab order.
Various population densities were tested, including 0% (confirmed no cells =
were alive) and 100% (confirmed that all cells were alive.)
All combinations of vertical/horizontal/no reflection were tested at odd an=
d even heights and widths, square and non-square.
Tests consisted of setting the proper configuration options, then watching =
the board for a few generations and confirming that no crashes occurred and=
that all cells appeared to live and die properly. =
Screenshots
-----------
Updated Configuration Dialog
http://reviewboard.kde.org/r/5027/s/481/
Board Using Vertical and Horizontal Reflection
http://reviewboard.kde.org/r/5027/s/482/
Thanks,
obby
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5027/">http://reviewboard.kde.org/r/5027/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By obby.</div>
<p style="color: grey;"><i>Updated 2010-08-23 19:12:21.184543</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The updated diff is built on top of the bugfix which was submitted as \
1166819 in trunk (http://reviewboard.kde.org/r/5055/)
Also included in the updated diff are member variable renamings (prepending m_ to \
member variable names.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update (8/23/10): The patch adds two new features to the life applet: \
game board reflection (the user can choose to generate initial populations that are \
symmetrical about the horizontal and/or vertical axes,) and user-configurable \
population density (the user can choose what approximate percentage of cells will be \
alive in the initial population.)
With the addition of the new configuration options, the configuration UI was also \
updated so that using tab to scroll through options would be consistent (top to \
bottom.)
This submit also includes member variable renamings (prepending m_ to member variable \
names.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Various game board sizes were tested (odd and even heights and widths, \
square and non-square.) The configuration dialog was opened several times and tested \
to confirm tab order.
Various population densities were tested, including 0% (confirmed no cells were \
alive) and 100% (confirmed that all cells were alive.)
All combinations of vertical/horizontal/no reflection were tested at odd and even \
heights and widths, square and non-square.
Tests consisted of setting the proper configuration options, then watching the board \
for a few generations and confirming that no crashes occurred and that all cells \
appeared to live and die properly. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/applets/life/life.h <span style="color: \
grey">(1166777)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/life/life.cpp <span style="color: \
grey">(1167084)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui <span style="color: \
grey">(1166777)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5027/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/5027/s/481/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/08/14/Game_Of_Life_1_400x100.png" \
style="border: 1px black solid;" alt="Updated Configuration Dialog" /></a>
<a href="http://reviewboard.kde.org/r/5027/s/482/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/08/14/Game_Of_Life_2_400x100.png" \
style="border: 1px black solid;" alt="Board Using Vertical and Horizontal Reflection" \
/></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic