From kde-panel-devel Mon Aug 23 19:12:21 2010
From: the.goofeedude () gmail ! com
Date: Mon, 23 Aug 2010 19:12:21 +0000
To: kde-panel-devel
Subject: Re: Review Request: Game of Life Plasmoid -- Cleanup and
Message-Id: <20100823191221.21969.60466 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=128259077306611
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1116318994=="
--===============1116318994==
Content-Type: multipart/alternative;
boundary="===============7914259987942362285=="
--===============7914259987942362285==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5027/
-----------------------------------------------------------
(Updated 2010-08-23 19:12:21.184543)
Review request for Plasma.
Changes
-------
The updated diff is built on top of the bugfix which was submitted as 11668=
19 in trunk (http://reviewboard.kde.org/r/5055/)
Also included in the updated diff are member variable renamings (prepending=
m_ to member variable names.)
Summary (updated)
-------
Update (8/23/10): The patch adds two new features to the life applet: game =
board reflection (the user can choose to generate initial populations that =
are symmetrical about the horizontal and/or vertical axes,) and user-config=
urable population density (the user can choose what approximate percentage =
of cells will be alive in the initial population.)
With the addition of the new configuration options, the configuration UI wa=
s also updated so that using tab to scroll through options would be consist=
ent (top to bottom.)
This submit also includes member variable renamings (prepending m_ to membe=
r variable names.)
Diffs (updated)
-----
/trunk/KDE/kdeplasma-addons/applets/life/life.h 1166777 =
/trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1167084 =
/trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui 1166777 =
Diff: http://reviewboard.kde.org/r/5027/diff
Testing
-------
Various game board sizes were tested (odd and even heights and widths, squa=
re and non-square.) The configuration dialog was opened several times and t=
ested to confirm tab order.
Various population densities were tested, including 0% (confirmed no cells =
were alive) and 100% (confirmed that all cells were alive.)
All combinations of vertical/horizontal/no reflection were tested at odd an=
d even heights and widths, square and non-square.
Tests consisted of setting the proper configuration options, then watching =
the board for a few generations and confirming that no crashes occurred and=
that all cells appeared to live and die properly. =
Screenshots
-----------
Updated Configuration Dialog
http://reviewboard.kde.org/r/5027/s/481/
Board Using Vertical and Horizontal Reflection
http://reviewboard.kde.org/r/5027/s/482/
Thanks,
obby
--===============7914259987942362285==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Review request for Plasma.
By obby.
Updated 2010-08-23 19:12:21.184543
Changes=
h1>
The updated diff is built on top of the bugfix which was sub=
mitted as 1166819 in trunk (http://reviewboard.kde.org/r/5055/)
Also included in the updated diff are member variable renamings (prepending=
m_ to member variable names.)
|
Descripti=
on (updated)
Update (8/23/10): The patch adds two new features to the lif=
e applet: game board reflection (the user can choose to generate initial po=
pulations that are symmetrical about the horizontal and/or vertical axes,) =
and user-configurable population density (the user can choose what approxim=
ate percentage of cells will be alive in the initial population.)
With the addition of the new configuration options, the configuration UI wa=
s also updated so that using tab to scroll through options would be consist=
ent (top to bottom.)
This submit also includes member variable renamings (prepending m_ to membe=
r variable names.)
|
Testing <=
/h1>
Various game board sizes were tested (odd and even heights a=
nd widths, square and non-square.) The configuration dialog was opened seve=
ral times and tested to confirm tab order.
Various population densities were tested, including 0% (confirmed no cells =
were alive) and 100% (confirmed that all cells were alive.)
All combinations of vertical/horizontal/no reflection were tested at odd an=
d even heights and widths, square and non-square.
Tests consisted of setting the proper configuration options, then watching =
the board for a few generations and confirming that no crashes occurred and=
that all cells appeared to live and die properly.
|
Diffs=
(updated)
- /trunk/KDE/kdeplasma-addons/applets/life/life.h (1166777)
- /trunk/KDE/kdeplasma-addons/applets/life/life.cpp (1167084)
- /trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui (1166777)
View Diff
Screensho=
ts
|
--===============7914259987942362285==--
--===============1116318994==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--===============1116318994==--