[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Game of Life Plasmoid -- Cleanup and
From: the.goofeedude () gmail ! com
Date: 2010-08-16 18:20:28
Message-ID: 20100816182028.18246.74314 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-08-15 07:56:46, Marco Martin wrote:
> > that'a a good feature.
> > would be possible separe in two commits, bugfix and feature? the bugfix=
one (and only that) should be backported to 4.5
> =
> obby wrote:
> I definitely can split this up into two commits. Should I include the=
variable renaming below (prepending m_ to member variables) in the bugfix =
submit? Or should I include them as part of the feature submit (or a new co=
mmit altogether?)
> =
> Also, I have applied for a kdesvn account, but currently have not hea=
rd back. I can upload an updated diff here for the feature, and an addition=
al diff for the bugfix, but I'll need a kind reviewer to commit each after =
they pass review.
> =
> Thanks!
> =
> Marco Martin wrote:
> yes, the variable renaming should be in the feature one.
> I hope your account gets approved soon.
> in the meantime i could do it if it would still not have been approve=
d.
I've opened http://reviewboard.kde.org/r/5055/ for the bugfix. Once that is=
submitted, I'll have quite an easier time creating an updated diff for jus=
t the feature addition here. I'll update the description here after the bug=
fix is in as well.
- obby
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5027/#review7060
-----------------------------------------------------------
On 2010-08-14 22:51:07, obby wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5027/
> -----------------------------------------------------------
> =
> (Updated 2010-08-14 22:51:07)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> This patch fixes a bug wherein the very last cell in the board would neve=
r come alive. Also, the configuration UI was updated so that using "tab" to=
scroll through options would be consistent (top to bottom.)
> =
> The patch also adds to new features: game board reflection (the user can =
choose to generate initial populations that are symmetrical about the horiz=
ontal and/or vertical axes,) and user-configurable population density (the =
user can choose what approximate percentage of cells will be alive in the i=
nitial population.)
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeplasma-addons/applets/life/life.h 1163310 =
> /trunk/KDE/kdeplasma-addons/applets/life/life.cpp 1163310 =
> /trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui 1163310 =
> =
> Diff: http://reviewboard.kde.org/r/5027/diff
> =
> =
> Testing
> -------
> =
> Various game board sizes were tested (odd and even heights and widths, sq=
uare and non-square.) The configuration dialog was opened several times and=
tested to confirm tab order.
> =
> Various population densities were tested, including 0% (confirmed no cell=
s were alive) and 100% (confirmed that all cells were alive.)
> =
> All combinations of vertical/horizontal/no reflection were tested at odd =
and even heights and widths, square and non-square.
> =
> Tests consisted of setting the proper configuration options, then watchin=
g the board for a few generations and confirming that no crashes occurred a=
nd that all cells appeared to live and die properly. =
> =
> =
> Screenshots
> -----------
> =
> Updated Configuration Dialog
> http://reviewboard.kde.org/r/5027/s/481/
> Board Using Vertical and Horizontal Reflection
> http://reviewboard.kde.org/r/5027/s/482/
> =
> =
> Thanks,
> =
> obby
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5027/">http://reviewboard.kde.org/r/5027/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 15th, 2010, 7:56 a.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">that'a a good feature. would be possible separe in two commits, \
bugfix and feature? the bugfix one (and only that) should be backported to 4.5</pre> \
</blockquote>
<p>On August 16th, 2010, 2:52 p.m., <b>obby</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I definitely can split \
this up into two commits. Should I include the variable renaming below (prepending m_ \
to member variables) in the bugfix submit? Or should I include them as part of the \
feature submit (or a new commit altogether?)
Also, I have applied for a kdesvn account, but currently have not heard back. I can \
upload an updated diff here for the feature, and an additional diff for the bugfix, \
but I'll need a kind reviewer to commit each after they pass review.
Thanks!</pre>
</blockquote>
<p>On August 16th, 2010, 2:59 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, the variable \
renaming should be in the feature one. I hope your account gets approved soon.
in the meantime i could do it if it would still not have been approved.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've opened \
http://reviewboard.kde.org/r/5055/ for the bugfix. Once that is submitted, I'll \
have quite an easier time creating an updated diff for just the feature addition \
here. I'll update the description here after the bugfix is in as well.</pre> <br \
/>
<p>- obby</p>
<br />
<p>On August 14th, 2010, 10:51 p.m., obby wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By obby.</div>
<p style="color: grey;"><i>Updated 2010-08-14 22:51:07</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a bug wherein the very last cell in the board would \
never come alive. Also, the configuration UI was updated so that using \
"tab" to scroll through options would be consistent (top to bottom.)
The patch also adds to new features: game board reflection (the user can choose to \
generate initial populations that are symmetrical about the horizontal and/or \
vertical axes,) and user-configurable population density (the user can choose what \
approximate percentage of cells will be alive in the initial population.)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Various game board sizes were tested (odd and even heights and widths, \
square and non-square.) The configuration dialog was opened several times and tested \
to confirm tab order.
Various population densities were tested, including 0% (confirmed no cells were \
alive) and 100% (confirmed that all cells were alive.)
All combinations of vertical/horizontal/no reflection were tested at odd and even \
heights and widths, square and non-square.
Tests consisted of setting the proper configuration options, then watching the board \
for a few generations and confirming that no crashes occurred and that all cells \
appeared to live and die properly. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/applets/life/life.h <span style="color: \
grey">(1163310)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/life/life.cpp <span style="color: \
grey">(1163310)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui <span style="color: \
grey">(1163310)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5027/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/5027/s/481/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/08/14/Game_Of_Life_1_400x100.png" \
style="border: 1px black solid;" alt="Updated Configuration Dialog" /></a>
<a href="http://reviewboard.kde.org/r/5027/s/482/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/08/14/Game_Of_Life_2_400x100.png" \
style="border: 1px black solid;" alt="Board Using Vertical and Horizontal Reflection" \
/></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic