This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5027/

Review request for Plasma.

By obby.

Updated 2010-08-23 19:12:21.184543

Changes

The updated diff is built on top of the bugfix which was sub=
mitted as 1166819 in trunk (http://reviewboard.kde.org/r/5055/)

Also included in the updated diff are member variable renamings (prepending=
 m_ to member variable names.)

Descripti= on (updated)

Update (8/23/10): The patch adds two new features to the lif=
e applet: game board reflection (the user can choose to generate initial po=
pulations that are symmetrical about the horizontal and/or vertical axes,) =
and user-configurable population density (the user can choose what approxim=
ate percentage of cells will be alive in the initial population.)

With the addition of the new configuration options, the configuration UI wa=
s also updated so that using tab to scroll through options would be consist=
ent (top to bottom.)

This submit also includes member variable renamings (prepending m_ to membe=
r variable names.)

Testing <= /h1>

Various game board sizes were tested (odd and even heights a=
nd widths, square and non-square.) The configuration dialog was opened seve=
ral times and tested to confirm tab order.

Various population densities were tested, including 0% (confirmed no cells =
were alive) and 100% (confirmed that all cells were alive.)

All combinations of vertical/horizontal/no reflection were tested at odd an=
d even heights and widths, square and non-square.

Tests consisted of setting the proper configuration options, then watching =
the board for a few generations and confirming that no crashes occurred and=
 that all cells appeared to live and die properly.

Diffs= (updated)

/trunk/KDE/kdeplasma-addons/applets/life/life.h (1166777)
/trunk/KDE/kdeplasma-addons/applets/life/life.cpp (1167084)
/trunk/KDE/kdeplasma-addons/applets/life/lifeConfig.ui (1166777)

View Diff

Screensho= ts

Changes The updated diff is built on top of the bugfix which was sub= mitted as 1166819 in trunk (http://reviewboard.kde.org/r/5055/) Also included in the updated diff are member variable renamings (prepending= m_ to member variable names.)

Descripti= on (updated)

Diffs= (updated)

Screensho= ts

Changes

The updated diff is built on top of the bugfix which was sub= mitted as 1166819 in trunk (http://reviewboard.kde.org/r/5055/) Also included in the updated diff are member variable renamings (prepending= m_ to member variable names.)