[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Update WebShortcutRunner to handle complex
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-06-29 16:12:50
Message-ID: 20100629161250.18243.85358 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4490/#review6318
-----------------------------------------------------------
Ship it!
a couple of minor ws issues, but the actual code is the right direction. this entire \
plugin needs to be ported to KUriFilter now that it has support in 4.5 for all the \
things the krunner plugin requires. this is a good start to that. please commit to \
trunk and backport to the 4.5 branch. (holler if you need a hand with the latter)
/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp
<http://reviewboard.kde.org/r/4490/#comment6048>
no spaces inside of ()s.
/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp
<http://reviewboard.kde.org/r/4490/#comment6047>
()s around the return statement are not necessary
- Aaron
On 2010-06-28 20:27:24, Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4490/
> -----------------------------------------------------------
>
> (Updated 2010-06-28 20:27:24)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch updates the web shortcuts runner so that it can handle substitutions \
> other than the basic \\{@}. Some of the web shortcuts provided with kdebase - e.g. \
> cpan, docbook, google_code - use \\{number} substitutions.
> This is done by replacing the body of WebshortcutRunner::searchQuery() to simply \
> call the kurisearchfilter URI filter.
>
> This addresses bug 242156.
> https://bugs.kde.org/show_bug.cgi?id=242156
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp \
> 1139171
> Diff: http://reviewboard.kde.org/r/4490/diff
>
>
> Testing
> -------
>
> Checked KRunner with patch applied, all web shortcuts are handled correctly.
>
>
> Thanks,
>
> Jonathan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4490/">http://reviewboard.kde.org/r/4490/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>a couple of minor ws issues, but the actual code is the right direction. this \
entire plugin needs to be ported to KUriFilter now that it has support in 4.5 for all \
the things the krunner plugin requires. this is a good start to that. please commit \
to trunk and backport to the 4.5 branch. (holler if you need a hand with the \
latter)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4490/diff/1/?file=29893#file29893line197" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">void \
WebshortcutRunner::match(Plasma::RunnerContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">196</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="k">if</span> <span class="p">(</span><span \
class="n">searchWord</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">())</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">197</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="n">KUriFilter</span><span class="o">::</span><span \
class="n">self</span><span class="p">()</span><span class="o">-></span><span \
class="n">filterUri</span><span class="p">(</span> <span class="n">q</span><span \
class="p">,</span> <span class="n">QStringList</span><span class="p">(</span><span \
class="s">"kurisearchfilter"</span> <span class="p">));</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">no spaces inside of ()s.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4490/diff/1/?file=29893#file29893line199" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">void \
WebshortcutRunner::match(Plasma::RunnerContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">198</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"> <span class="p">}</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">199</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: \
pre-wrap; word-wrap: break-word;"> <span class="k">return</span> <span \
class="p">(</span><span class="n">q</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em">()s around the return statement are not necessary</pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On June 28th, 2010, 8:27 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated 2010-06-28 20:27:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch updates the web shortcuts runner so \
that it can handle substitutions other than the basic \\{@}. Some of the web \
shortcuts provided with kdebase - e.g. cpan, docbook, google_code - use \\{number} \
substitutions.
This is done by replacing the body of WebshortcutRunner::searchQuery() to simply call \
the kurisearchfilter URI filter. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Checked KRunner with patch applied, all web \
shortcuts are handled correctly. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=242156">242156</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp \
<span style="color: grey">(1139171)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4490/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic