[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Update WebShortcutRunner to handle complex
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2010-06-28 20:27:24
Message-ID: 20100628202724.22838.91165 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4490/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
This patch updates the web shortcuts runner so that it can handle substitutions other \
than the basic \\{@}. Some of the web shortcuts provided with kdebase - e.g. cpan, \
docbook, google_code - use \\{number} substitutions.
This is done by replacing the body of WebshortcutRunner::searchQuery() to simply call \
the kurisearchfilter URI filter.
This addresses bug 242156.
https://bugs.kde.org/show_bug.cgi?id=242156
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp \
1139171
Diff: http://reviewboard.kde.org/r/4490/diff
Testing
-------
Checked KRunner with patch applied, all web shortcuts are handled correctly.
Thanks,
Jonathan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4490/">http://reviewboard.kde.org/r/4490/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Marten.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch updates the web shortcuts runner so \
that it can handle substitutions other than the basic \\{@}. Some of the web \
shortcuts provided with kdebase - e.g. cpan, docbook, google_code - use \\{number} \
substitutions.
This is done by replacing the body of WebshortcutRunner::searchQuery() to simply call \
the kurisearchfilter URI filter. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Checked KRunner with patch applied, all web \
shortcuts are handled correctly. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=242156">242156</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp \
<span style="color: grey">(1139171)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4490/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic