--===============1784734825== Content-Type: multipart/alternative; boundary="===============7735263836518695085==" --===============7735263836518695085== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4490/#review6318 ----------------------------------------------------------- Ship it! a couple of minor ws issues, but the actual code is the right direction. th= is entire plugin needs to be ported to KUriFilter now that it has support i= n 4.5 for all the things the krunner plugin requires. this is a good start = to that. please commit to trunk and backport to the 4.5 branch. (holler if = you need a hand with the latter) /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcu= trunner.cpp no spaces inside of ()s. /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcu= trunner.cpp ()s around the return statement are not necessary - Aaron On 2010-06-28 20:27:24, Jonathan Marten wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4490/ > ----------------------------------------------------------- > = > (Updated 2010-06-28 20:27:24) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > This patch updates the web shortcuts runner so that it can handle substit= utions other than the basic \\{@}. Some of the web shortcuts provided with= kdebase - e.g. cpan, docbook, google_code - use \\{number} substitutions. > = > This is done by replacing the body of WebshortcutRunner::searchQuery() to= simply call the kurisearchfilter URI filter. > = > = > This addresses bug 242156. > https://bugs.kde.org/show_bug.cgi?id=3D242156 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/websho= rtcutrunner.cpp 1139171 = > = > Diff: http://reviewboard.kde.org/r/4490/diff > = > = > Testing > ------- > = > Checked KRunner with patch applied, all web shortcuts are handled correct= ly. > = > = > Thanks, > = > Jonathan > = > --===============7735263836518695085== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4490/

Ship it!

a couple of minor ws issues, but the actual code is the right directi=
on. this entire plugin needs to be ported to KUriFilter now that it has sup=
port in 4.5 for all the things the krunner plugin requires. this is a good =
start to that. please commit to trunk and backport to the 4.5 branch. (holl=
er if you need a hand with the latter)

= =
/trunk/KDE/kdebas= e/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp (Diff revision 1) 
void WebshortcutRunner=
::match(Plasma::RunnerContext &context)
196 
 =
   if (=
searchWord.isEmpty=
()) {
 197 
 =
   KUriFilter::self()->filterUri( q, QStringList("kurisearchfilter"=
 ));
 
no spaces inside of ()s.

= =
/trunk/KDE/kdebas= e/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp (Diff revision 1) 
void WebshortcutRunner=
::match(Plasma::RunnerContext &context)
198 
 =
   }
 199 
 =
   return (q);
 
()s around the return statement are not nec=
essary

- Aaron


On June 28th, 2010, 8:27 p.m., Jonathan Marten wrote:

Review request for Plasma.
By Jonathan Marten.

Updated 2010-06-28 20:27:24

Descripti= on 

This patch updates the web shortcu=
ts runner so that it can handle substitutions other than the basic \\{@}.  =
Some of the web shortcuts provided with kdebase - e.g. cpan, docbook, googl=
e_code - use \\{number} substitutions.

This is done by replacing the body of WebshortcutRunner::searchQuery() to s=
imply call the kurisearchfilter URI filter.

Testing <= /h1> 
Checked KRunner with patch applied=
, all web shortcuts are handled correctly.
Bugs: 242156

Diffs=

  • /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/websh= ortcutrunner.cpp (1139171)

View Diff
--===============7735263836518695085==-- --===============1784734825== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1784734825==--