This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4490/

Ship it!

a couple of minor ws issues, but the actual code is the right direction. this entire plugin needs to be ported to KUriFilter now that it has support in 4.5 for all the things the krunner plugin requires. this is a good start to that. please commit to trunk and backport to the 4.5 branch. (holler if you need a hand with the latter)

/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp (Diff revision 1) 
void WebshortcutRunner::match(Plasma::RunnerContext &context)
196 
    if (searchWord.isEmpty()) {
 197 
    KUriFilter::self()->filterUri( q, QStringList("kurisearchfilter" ));
 
no spaces inside of ()s.

/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp (Diff revision 1) 
void WebshortcutRunner::match(Plasma::RunnerContext &context)
198 
    }
 199 
    return (q);
 
()s around the return statement are not necessary

- Aaron


On June 28th, 2010, 8:27 p.m., Jonathan Marten wrote:

Review request for Plasma.
By Jonathan Marten.

Updated 2010-06-28 20:27:24

Description 

This patch updates the web shortcuts runner so that it can handle substitutions other than the basic \\{@}.  Some of the web shortcuts provided with kdebase - e.g. cpan, docbook, google_code - use \\{number} substitutions.

This is done by replacing the body of WebshortcutRunner::searchQuery() to simply call the kurisearchfilter URI filter.

Testing 

Checked KRunner with patch applied, all web shortcuts are handled correctly.
Bugs: 242156

Diffs

  • /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp (1139171)

View Diff