[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Allows selection of icons using the SHIFT key.
From:       Shantanu Tushar Jha <jhahoneyk () gmail ! com>
Date:       2009-09-28 17:29:33
Message-ID: ec556b640909281017u63c7adf8r41be1927677e593e () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


If this might be useful, please review. Thanks :)

On Thu, Sep 24, 2009 at 10:07 PM, Shantanu Tushar Jha
<jhahoneyk@gmail.com>wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1709/
> -----------------------------------------------------------
>
> (Updated 2009-09-24 16:37:05.117590)
>
>
> Review request for Plasma.
>
>
> Changes
> -------
>
> When a key is pressed, then instead of repainting whole visible area only
> repaint the icons which were previously selected.
>
>
> Summary (updated)
> -------
>
> If the view is arranged (i.e. m_layoutBroken is false), the icons between
> the previous and the current click are selected linearly. If the view is
> broken, the icons which are in the rectangular region of the previous and
> currently selected icon, are selected. This is because when the view is
> broken, there is no 'linearity' as such.
> A minor change to key functionality - When a key is pressed, the icons
> which were previously selected are repainted.
>
>
> This addresses bug 189359.
>    https://bugs.kde.org/show_bug.cgi?id=189359
>
>
> Diffs (updated)
> -----
>
>  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1027710
>  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1027710
>
> Diff: http://reviewboard.kde.org/r/1709/diff
>
>
> Testing
> -------
>
> Tested on current trunk build. Works fine.
>
>
> Thanks,
>
> Shantanu
>
>


-- 
Shantanu Tushar    (UTC +0530)
http://www.shantanutushar.com

[Attachment #5 (text/html)]

If this might be useful, please review. Thanks :)<br><br><div class="gmail_quote">On \
Thu, Sep 24, 2009 at 10:07 PM, Shantanu Tushar Jha <span dir="ltr">&lt;<a \
href="mailto:jhahoneyk@gmail.com">jhahoneyk@gmail.com</a>&gt;</span> wrote:<br> \
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
                margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/1709/" \
                target="_blank">http://reviewboard.kde.org/r/1709/</a><br>
-----------------------------------------------------------<br>
<br>
</div>(Updated 2009-09-24 16:37:05.117590)<br>
<br>
<br>
Review request for Plasma.<br>
<br>
<br>
Changes<br>
-------<br>
<br>
When a key is pressed, then instead of repainting whole visible area only repaint the \
icons which were previously selected.<br> <br>
<br>
Summary (updated)<br>
<div class="im">-------<br>
<br>
If the view is arranged (i.e. m_layoutBroken is false), the icons between the \
previous and the current click are selected linearly. If the view is broken, the \
icons which are in the rectangular region of the previous and currently selected \
icon, are selected. This is because when the view is broken, there is no \
&#39;linearity&#39; as such.<br>

</div>A minor change to key functionality - When a key is pressed, the icons which \
were previously selected are repainted.<br> <div><div></div><div class="h5"><br>
<br>
This addresses bug 189359.<br>
    <a href="https://bugs.kde.org/show_bug.cgi?id=189359" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=189359</a><br> <br>
<br>
Diffs (updated)<br>
-----<br>
<br>
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1027710<br>
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1027710<br>
<br>
Diff: <a href="http://reviewboard.kde.org/r/1709/diff" \
target="_blank">http://reviewboard.kde.org/r/1709/diff</a><br> <br>
<br>
Testing<br>
-------<br>
<br>
Tested on current trunk build. Works fine.<br>
<br>
<br>
Thanks,<br>
<br>
Shantanu<br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Shantanu Tushar    (UTC \
+0530)<br><a href="http://www.shantanutushar.com">http://www.shantanutushar.com</a><br>




_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]