[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Allows selection of icons using the SHIFT key.
From:       "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date:       2009-10-04 13:46:56
Message-ID: 20091004134656.17045.22517 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1709/
-----------------------------------------------------------

(Updated 2009-10-04 13:46:56.620748)


Review request for Plasma and Fredrik Höglund.


Changes
-------

As Fredrik H told on IRC, rubber band selection code had to be reused, so moved that \
to a function. Used built-in Qt method to select a range of icons.


Summary
-------

If the view is arranged (i.e. m_layoutBroken is false), the icons between the \
previous and the current click are selected linearly. If the view is broken, the \
icons which are in the rectangular region of the previous and currently selected \
icon, are selected. This is because when the view is broken, there is no 'linearity' \
as such. A minor change to key functionality - When a key is pressed, the icons which \
were previously selected are repainted.


This addresses bug 189359.
    https://bugs.kde.org/show_bug.cgi?id=189359


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1031204 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1031204 

Diff: http://reviewboard.kde.org/r/1709/diff


Testing
-------

Tested on current trunk build. Works fine.


Thanks,

Shantanu

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]