--===============1999294790==
Content-Type: multipart/alternative; boundary=00c09f89980e2beab20474a67972

--00c09f89980e2beab20474a67972
Content-Type: text/plain; charset=ISO-8859-1

If this might be useful, please review. Thanks :)

On Thu, Sep 24, 2009 at 10:07 PM, Shantanu Tushar Jha
<jhahoneyk@gmail.com>wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1709/
> -----------------------------------------------------------
>
> (Updated 2009-09-24 16:37:05.117590)
>
>
> Review request for Plasma.
>
>
> Changes
> -------
>
> When a key is pressed, then instead of repainting whole visible area only
> repaint the icons which were previously selected.
>
>
> Summary (updated)
> -------
>
> If the view is arranged (i.e. m_layoutBroken is false), the icons between
> the previous and the current click are selected linearly. If the view is
> broken, the icons which are in the rectangular region of the previous and
> currently selected icon, are selected. This is because when the view is
> broken, there is no 'linearity' as such.
> A minor change to key functionality - When a key is pressed, the icons
> which were previously selected are repainted.
>
>
> This addresses bug 189359.
>    https://bugs.kde.org/show_bug.cgi?id=189359
>
>
> Diffs (updated)
> -----
>
>  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1027710
>  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1027710
>
> Diff: http://reviewboard.kde.org/r/1709/diff
>
>
> Testing
> -------
>
> Tested on current trunk build. Works fine.
>
>
> Thanks,
>
> Shantanu
>
>


-- 
Shantanu Tushar    (UTC +0530)
http://www.shantanutushar.com

--00c09f89980e2beab20474a67972
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

If this might be useful, please review. Thanks :)<br><br><div class=3D"gmai=
l_quote">On Thu, Sep 24, 2009 at 10:07 PM, Shantanu Tushar Jha <span dir=3D=
"ltr">&lt;<a href=3D"mailto:jhahoneyk@gmail.com">jhahoneyk@gmail.com</a>&gt=
;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class=3D"im"=
><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href=3D"http://reviewboard.kde.org/r/1709/" target=3D"_blank">http://rev=
iewboard.kde.org/r/1709/</a><br>
-----------------------------------------------------------<br>
<br>
</div>(Updated 2009-09-24 16:37:05.117590)<br>
<br>
<br>
Review request for Plasma.<br>
<br>
<br>
Changes<br>
-------<br>
<br>
When a key is pressed, then instead of repainting whole visible area only r=
epaint the icons which were previously selected.<br>
<br>
<br>
Summary (updated)<br>
<div class=3D"im">-------<br>
<br>
If the view is arranged (i.e. m_layoutBroken is false), the icons between t=
he previous and the current click are selected linearly. If the view is bro=
ken, the icons which are in the rectangular region of the previous and curr=
ently selected icon, are selected. This is because when the view is broken,=
 there is no &#39;linearity&#39; as such.<br>

</div>A minor change to key functionality - When a key is pressed, the icon=
s which were previously selected are repainted.<br>
<div><div></div><div class=3D"h5"><br>
<br>
This addresses bug 189359.<br>
 =A0 =A0<a href=3D"https://bugs.kde.org/show_bug.cgi?id=3D189359" target=3D=
"_blank">https://bugs.kde.org/show_bug.cgi?id=3D189359</a><br>
<br>
<br>
Diffs (updated)<br>
-----<br>
<br>
 =A0/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1027710<br=
>
 =A0/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1027710<=
br>
<br>
Diff: <a href=3D"http://reviewboard.kde.org/r/1709/diff" target=3D"_blank">=
http://reviewboard.kde.org/r/1709/diff</a><br>
<br>
<br>
Testing<br>
-------<br>
<br>
Tested on current trunk build. Works fine.<br>
<br>
<br>
Thanks,<br>
<br>
Shantanu<br>
<br>
</div></div></blockquote></div><br><br clear=3D"all"><br>-- <br>Shantanu Tu=
shar =A0 =A0(UTC +0530)<br><a href=3D"http://www.shantanutushar.com">http:/=
/www.shantanutushar.com</a><br>

--00c09f89980e2beab20474a67972--

--===============1999294790==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1999294790==--