On Thu, Sep 24, 2009 at 10:07 PM, Shantanu Tushar Jha <jhahoneyk@gmail.com> wrote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1709/
-----------------------------------------------------------

(Updated 2009-09-24 16:37:05.117590)

Review request for Plasma.

Changes
-------

When a key is pressed, then instead of repainting whole visible area only repaint the icons which were previously selected.

Summary (updated)

-------

If the view is arranged (i.e. m_layoutBroken is false), the icons between the previous and the current click are selected linearly. If the view is broken, the icons which are in the rectangular region of the previous and currently selected icon, are selected. This is because when the view is broken, there is no 'linearity' as such.

A minor change to key functionality - When a key is pressed, the icons which were previously selected are repainted.

This addresses bug 189359.
https://bugs.kde.org/show_bug.cgi?id=189359

Diffs (updated)
-----

/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1027710
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1027710

Diff: http://reviewboard.kde.org/r/1709/diff

Testing
-------

Tested on current trunk build. Works fine.

Thanks,

Shantanu