'Re: [KDE/Mac] Review Request 128358: QtCurve-qt5 : start weaning off KDELibs4Support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    Re: [KDE/Mac] Review Request 128358: QtCurve-qt5 : start weaning off KDELibs4Support
From:       Yichao Yu <yyc1992 () gmail ! com>
Date:       2016-07-25 15:14:55
Message-ID: 20160725151455.4620.70312 () mimi ! kde ! org
[Download RAW message or body]

--===============7071810290856579104==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128358/#review97835
-----------------------------------------------------------

Ship it!

LGTM.

Just to make sure, the ones that replaces KDE settings with Qt ones are now sync'd to \
the Qt settings on Qt5 right?

- Yichao Yu

On 七月 4, 2016, 2:42 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128358/
> -----------------------------------------------------------
> 
> (Updated 七月 4, 2016, 2:42 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> The title says it all; QtCurve should be weaned off KDELibs4Support.
> This first step uses current APIs for the KDE4 APIs that have been deprecated \
> explicitly. 
> 
> Diffs
> -----
> 
> qt5/style/qtcurve.h d9395bc 
> qt5/style/qtcurve.cpp 929ec81 
> qt5/style/qtcurve_api.cpp 4e95e15 
> qt5/style/qtcurve_primitive.cpp 758fdf1 
> qt5/style/windowmanager.cpp 225d363 
> 
> Diff: https://git.reviewboard.kde.org/r/128358/diff/
> 
> 
> Testing
> -------
> 
> On OS X and Linux with Qt 5.6.1
> 
> I think it'd be important for this ticket if 1 or 2 others test the patch on their \
> end to be sure we've had reasonable coverage of the rather large settings space \
> before we commit anything. 
> 
> Thanks,
> 
> René J.V. Bertin
> 
> 

--===============7071810290856579104==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128358/">https://git.reviewboard.kde.org/r/128358/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">LGTM.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Just to make sure, the ones that \
replaces KDE settings with Qt ones are now sync'd to the Qt settings on Qt5 \
right?</p></pre>  <br />

<p>- Yichao Yu</p>

<br />
<p>On 七月 4th, 2016, 2:42 p.m. EDT, René J.V. Bertin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated 七月 4, 2016, 2:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The title says it all; QtCurve should be weaned off \
KDELibs4Support. This first step uses current APIs for the KDE4 APIs that have been \
deprecated explicitly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X and Linux with Qt 5.6.1</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it'd be important for this ticket if 1 or 2 others test the patch on their end \
to be sure we've had reasonable coverage of the rather large settings space before we \
commit anything.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>qt5/style/qtcurve.h <span style="color: grey">(d9395bc)</span></li>

 <li>qt5/style/qtcurve.cpp <span style="color: grey">(929ec81)</span></li>

 <li>qt5/style/qtcurve_api.cpp <span style="color: grey">(4e95e15)</span></li>

 <li>qt5/style/qtcurve_primitive.cpp <span style="color: grey">(758fdf1)</span></li>

 <li>qt5/style/windowmanager.cpp <span style="color: grey">(225d363)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128358/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7071810290856579104==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac

[prev in list] [next in list] [prev in thread] [next in thread] 