[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: [KDE/Mac] Review Request 128358: QtCurve-qt5 : start weaning off KDELibs4Support
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2016-07-04 18:42:18
Message-ID: 20160704184218.5371.7828 () mimi ! kde ! org
[Download RAW message or body]
--===============3140397894196952234==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128358/
-----------------------------------------------------------
Review request for KDE Software on Mac OS X and Yichao Yu.
Repository: qtcurve
Description
-------
The title says it all; QtCurve should be weaned off KDELibs4Support.
This first step uses current APIs for the KDE4 APIs that have been deprecated \
explicitly.
Diffs
-----
qt5/style/qtcurve.h d9395bc
qt5/style/qtcurve.cpp 929ec81
qt5/style/qtcurve_api.cpp 4e95e15
qt5/style/qtcurve_primitive.cpp 758fdf1
qt5/style/windowmanager.cpp 225d363
Diff: https://git.reviewboard.kde.org/r/128358/diff/
Testing
-------
On OS X and Linux with Qt 5.6.1
I think it'd be important for this ticket if 1 or 2 others test the patch on their \
end to be sure we've had reasonable coverage of the rather large settings space \
before we commit anything.
Thanks,
René J.V. Bertin
--===============3140397894196952234==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128358/">https://git.reviewboard.kde.org/r/128358/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The title says it all; QtCurve should be weaned off \
KDELibs4Support. This first step uses current APIs for the KDE4 APIs that have been \
deprecated explicitly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X and Linux with Qt 5.6.1</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it'd be important for this ticket if 1 or 2 others test the patch on their end \
to be sure we've had reasonable coverage of the rather large settings space before we \
commit anything.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>qt5/style/qtcurve.h <span style="color: grey">(d9395bc)</span></li>
<li>qt5/style/qtcurve.cpp <span style="color: grey">(929ec81)</span></li>
<li>qt5/style/qtcurve_api.cpp <span style="color: grey">(4e95e15)</span></li>
<li>qt5/style/qtcurve_primitive.cpp <span style="color: grey">(758fdf1)</span></li>
<li>qt5/style/windowmanager.cpp <span style="color: grey">(225d363)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128358/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3140397894196952234==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic