From kde-mac Mon Jul 25 15:14:55 2016 From: Yichao Yu Date: Mon, 25 Jul 2016 15:14:55 +0000 To: kde-mac Subject: Re: [KDE/Mac] Review Request 128358: QtCurve-qt5 : start weaning off KDELibs4Support Message-Id: <20160725151455.4620.70312 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-mac&m=146945970827509 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2313189520008828731==" --===============2313189520008828731== Content-Type: multipart/alternative; boundary="===============7071810290856579104==" --===============7071810290856579104== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128358/#review97835 ----------------------------------------------------------- Ship it! LGTM. Just to make sure, the ones that replaces KDE settings with Qt ones are now sync'd to the Qt settings on Qt5 right? - Yichao Yu On 七月 4, 2016, 2:42 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128358/ > ----------------------------------------------------------- > > (Updated 七月 4, 2016, 2:42 p.m.) > > > Review request for KDE Software on Mac OS X and Yichao Yu. > > > Repository: qtcurve > > > Description > ------- > > The title says it all; QtCurve should be weaned off KDELibs4Support. > This first step uses current APIs for the KDE4 APIs that have been deprecated explicitly. > > > Diffs > ----- > > qt5/style/qtcurve.h d9395bc > qt5/style/qtcurve.cpp 929ec81 > qt5/style/qtcurve_api.cpp 4e95e15 > qt5/style/qtcurve_primitive.cpp 758fdf1 > qt5/style/windowmanager.cpp 225d363 > > Diff: https://git.reviewboard.kde.org/r/128358/diff/ > > > Testing > ------- > > On OS X and Linux with Qt 5.6.1 > > I think it'd be important for this ticket if 1 or 2 others test the patch on their end to be sure we've had reasonable coverage of the rather large settings space before we commit anything. > > > Thanks, > > René J.V. Bertin > > --===============7071810290856579104== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128358/

Ship it!

LGTM.

Just to make sure, the ones that replaces KDE settings with Qt ones are now sync'd to the Qt settings on Qt5 right?

- Yichao Yu

On 七月 4th, 2016, 2:42 p.m. EDT, René J.V. Bertin wrote:

Review request for KDE Software on Mac OS X and Yichao Yu.

By René J.V. Bertin.

Updated 七月 4, 2016, 2:42 p.m.

Repository: qtcurve

Description

The title says it all; QtCurve should be weaned off KDELibs4Support. This first step uses current APIs for the KDE4 APIs that have been deprecated explicitly.

Testing

On OS X and Linux with Qt 5.6.1

I think it'd be important for this ticket if 1 or 2 others test the patch on their end to be sure we've had reasonable coverage of the rather large settings space before we commit anything.

Diffs

qt5/style/qtcurve.h (d9395bc)
qt5/style/qtcurve.cpp (929ec81)
qt5/style/qtcurve_api.cpp (4e95e15)
qt5/style/qtcurve_primitive.cpp (758fdf1)
qt5/style/windowmanager.cpp (225d363)

--===============7071810290856579104==-- --===============2313189520008828731== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2RlLW1hY0Br ZGUub3JnCkxpc3QgSW5mb3JtYXRpb246IGh0dHBzOi8vbWFpbC5rZGUub3JnL21haWxtYW4vbGlz dGluZm8va2RlLW1hYwpLREUvTWFjIEluZm9ybWF0aW9uOiBodHRwOi8vY29tbXVuaXR5LmtkZS5v cmcvTWFj --===============2313189520008828731==--