[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 113864: do not crash closing knavalbattle in the middle of an a
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2013-11-21 8:08:48
Message-ID: 20131121080848.19307.60468 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 20, 2013, 11:29 p.m., Albert Astals Cid wrote:
> > I think a better solution would be making the animator not a pure singleton but \
> > something that gets created and deleted by the window and then just deleting the \
> > animator on the window deletion, but that's a big rework, so yeah just commit \
> > this and then maybe work on the rework if you have time/stamina?
>
> Albert Astals Cid wrote:
> branches 4.11 and up, no?
Yes. Tonight (or tomorrow) it will be pushed to 4.11, 4.12 and master. Including your \
comment for a better solution (just in case).
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113864/#review44075
-----------------------------------------------------------
On Nov. 14, 2013, 4:05 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113864/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 4:05 p.m.)
>
>
> Review request for KDE Games and Roney Gomes.
>
>
> Bugs: 325126
> http://bugs.kde.org/show_bug.cgi?id=325126
>
>
> Repository: knavalbattle
>
>
> Description
> -------
>
> stop the animation when the main window is about to be closed.
>
>
> Diffs
> -----
>
> src/mainwindow.h dbac1f9
> src/mainwindow.cpp e3f2a35
>
> Diff: http://git.reviewboard.kde.org/r/113864/diff/
>
>
> Testing
> -------
>
> I was able to reproduce the crash easily, now I can't.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113864/">http://git.reviewboard.kde.org/r/113864/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2013, 11:29 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think a better solution would be making the animator not a pure \
singleton but something that gets created and deleted by the window and then just \
deleting the animator on the window deletion, but that's a big rework, so yeah \
just commit this and then maybe work on the rework if you have time/stamina?</pre> \
</blockquote>
<p>On November 20th, 2013, 11:30 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">branches 4.11 and up, \
no?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. Tonight (or \
tomorrow) it will be pushed to 4.11, 4.12 and master. Including your comment for a \
better solution (just in case). </pre> <br />
<p>- Jaime Torres</p>
<br />
<p>On November 14th, 2013, 4:05 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2013, 4:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325126">325126</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">stop the animation when the main window is about to be closed.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was able to reproduce the crash easily, now I can't.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.h <span style="color: grey">(dbac1f9)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(e3f2a35)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113864/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic