[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 113512: Animation fix for KReversi
From: "Denis Kuplyakov" <dener.kup () gmail ! com>
Date: 2013-11-21 4:55:58
Message-ID: 20131121045558.20786.65655 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 9, 2013, 11 p.m., Albert Astals Cid wrote:
> > Looks to me that it works like it did before the QML port, good job :-)
> >
> > Please commit to KDE/4.12 and then merge to master.
>
> Albert Astals Cid wrote:
> Denis? Did you commit this to master and not to KDE/4.12? Why?
Last time I have made changes, I have committed only to master... What should I do to fix things?
- Denis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113512/#review43312
-----------------------------------------------------------
On Nov. 5, 2013, 4:56 p.m., Denis Kuplyakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113512/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 4:56 p.m.)
>
>
> Review request for KDE Games, Albert Astals Cid and Viranch Mehta.
>
>
> Repository: kreversi
>
>
> Description
> -------
>
> This fixes animation for KReversi. Now chips are turning "as wave" from player's move position.
>
>
> Diffs
> -----
>
> kreversiview.h 2356fe7
> kreversiview.cpp b7a9ddf
> qml/Board.qml 60c6814
> qml/Cell.qml 2007265
> qml/Chip.qml 78d65bb
> qml/Table.qml 158ba65
>
> Diff: http://git.reviewboard.kde.org/r/113512/diff/
>
>
> Testing
> -------
>
> I have tested it a bit, seems to work.
>
>
> Thanks,
>
> Denis Kuplyakov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113512/">http://git.reviewboard.kde.org/r/113512/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 9th, 2013, 11 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks to me that it works like it did before the QML port, good job :-)
Please commit to KDE/4.12 and then merge to master.</pre>
</blockquote>
<p>On November 20th, 2013, 11:22 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Denis? Did you commit \
this to master and not to KDE/4.12? Why?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Last time I have made \
changes, I have committed only to master... What should I do to fix things? </pre> \
<br />
<p>- Denis</p>
<br />
<p>On November 5th, 2013, 4:56 p.m. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid and Viranch Mehta.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2013, 4:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kreversi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes animation for KReversi. Now chips are turning "as \
wave" from player's move position.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested it a bit, seems to work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kreversiview.h <span style="color: grey">(2356fe7)</span></li>
<li>kreversiview.cpp <span style="color: grey">(b7a9ddf)</span></li>
<li>qml/Board.qml <span style="color: grey">(60c6814)</span></li>
<li>qml/Cell.qml <span style="color: grey">(2007265)</span></li>
<li>qml/Chip.qml <span style="color: grey">(78d65bb)</span></li>
<li>qml/Table.qml <span style="color: grey">(158ba65)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113512/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic