From kde-games-devel Thu Nov 21 08:08:48 2013 From: "Jaime Torres Amate" Date: Thu, 21 Nov 2013 08:08:48 +0000 To: kde-games-devel Subject: Re: [Kde-games-devel] Review Request 113864: do not crash closing knavalbattle in the middle of an a Message-Id: <20131121080848.19307.60468 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-games-devel&m=138502134602529 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1408455444133386011==" --===============1408455444133386011== Content-Type: multipart/alternative; boundary="===============7344712278607639680==" --===============7344712278607639680== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Nov. 20, 2013, 11:29 p.m., Albert Astals Cid wrote: > > I think a better solution would be making the animator not a pure singleton but something that gets created and deleted by the window and then just deleting the animator on the window deletion, but that's a big rework, so yeah just commit this and then maybe work on the rework if you have time/stamina? > > Albert Astals Cid wrote: > branches 4.11 and up, no? Yes. Tonight (or tomorrow) it will be pushed to 4.11, 4.12 and master. Including your comment for a better solution (just in case). - Jaime Torres ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113864/#review44075 ----------------------------------------------------------- On Nov. 14, 2013, 4:05 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113864/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 4:05 p.m.) > > > Review request for KDE Games and Roney Gomes. > > > Bugs: 325126 > http://bugs.kde.org/show_bug.cgi?id=325126 > > > Repository: knavalbattle > > > Description > ------- > > stop the animation when the main window is about to be closed. > > > Diffs > ----- > > src/mainwindow.h dbac1f9 > src/mainwindow.cpp e3f2a35 > > Diff: http://git.reviewboard.kde.org/r/113864/diff/ > > > Testing > ------- > > I was able to reproduce the crash easily, now I can't. > > > Thanks, > > Jaime Torres Amate > > --===============7344712278607639680== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113864/

On November 20th, 2013, 11:29 p.m. UTC, Albert Astals Cid wrote:

I think a better solution would be making the animator not a pure singleton but something that gets created and deleted by the window and then just deleting the animator on the window deletion, but that's a big rework, so yeah just commit this and then maybe work on the rework if you have time/stamina?

On November 20th, 2013, 11:30 p.m. UTC, Albert Astals Cid wrote:

branches 4.11 and up, no?
Yes. Tonight (or tomorrow) it will be pushed to 4.11, 4.12 and master. Including your comment for a better solution (just in case).

- Jaime Torres


On November 14th, 2013, 4:05 p.m. UTC, Jaime Torres Amate wrote:

Review request for KDE Games and Roney Gomes.
By Jaime Torres Amate.

Updated Nov. 14, 2013, 4:05 p.m.

Bugs: 325126
Repository: knavalbattle

Description 

stop the animation when the main window is about to be closed.

Testing 

I was able to reproduce the crash easily, now I can't.

Diffs

  • src/mainwindow.h (dbac1f9)
  • src/mainwindow.cpp (e3f2a35)

View Diff
--===============7344712278607639680==-- --===============1408455444133386011== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel --===============1408455444133386011==--