[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 113854: avoid the game lock up
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2013-11-21 9:26:32
Message-ID: 20131121092632.2285.46225 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 20, 2013, 11:26 p.m., Albert Astals Cid wrote:
> > src/ai/ai.cpp, line 23
> > <http://git.reviewboard.kde.org/r/113854/diff/1/?file=214042#file214042line23>
> >
> > Why m_set->at and not m_sea->canHit like in the dummyAI getMove?
Because canHit() get the opponent field everytime, and I already have it outside the \
loop. Because there is no need to check the position, because it is generated valid \
with Coord(i,j) (it is always inside the board in the loop).
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113854/#review44074
-----------------------------------------------------------
On Nov. 14, 2013, 12:11 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113854/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 12:11 p.m.)
>
>
> Review request for KDE Games and Roney Gomes.
>
>
> Bugs: 246382
> http://bugs.kde.org/show_bug.cgi?id=246382
>
>
> Repository: knavalbattle
>
>
> Description
> -------
>
> Always return a valid move if there is still one.
> desperateMove does that, it checks one bye one the sea and returns the first free \
> coord or invalid if finally there are no free coords.
>
> Diffs
> -----
>
> src/ai/smartai.cpp 261cf01
> src/ai/ai.h 738c465
> src/ai/ai.cpp 384090f
> src/ai/dummyai.cpp 15544e2
>
> Diff: http://git.reviewboard.kde.org/r/113854/diff/
>
>
> Testing
> -------
>
> As I said in the bug, it happens when illegal move ( -1 , -1 ) for player x is \
> reached in Controller::finalizeShot. There are no more illegal moves (because the \
> AI never shoots first), and I've seen this new method called several times (when it \
> had kWarnings). Also, in more than 50 matches (implementing the several ships \
> feature), no more lockups.
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113854/">http://git.reviewboard.kde.org/r/113854/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2013, 11:26 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113854/diff/1/?file=214042#file214042line23" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ai/ai.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">23</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">m_sea</span><span \
class="o">-></span><span class="n">at</span><span class="p">(</span><span \
class="n">opp</span><span class="p">,</span> <span class="n">Coord</span><span \
class="p">(</span><span class="n">i</span><span class="p">,</span><span \
class="n">j</span><span class="p">)).</span><span class="n">free</span><span \
class="p">())</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why m_set->at and not \
m_sea->canHit like in the dummyAI getMove?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because \
canHit() get the opponent field everytime, and I already have it outside the loop. \
Because there is no need to check the position, because it is generated valid with \
Coord(i,j) (it is always inside the board in the loop). </pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On November 14th, 2013, 12:11 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2013, 12:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=246382">246382</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Always return a valid move if there is still one. desperateMove does \
that, it checks one bye one the sea and returns the first free coord or invalid if \
finally there are no free coords. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As I said in the bug, it happens when illegal move ( -1 , -1 ) for \
player x is reached in Controller::finalizeShot. There are no more illegal moves \
(because the AI never shoots first), and I've seen this new method called several \
times (when it had kWarnings). Also, in more than 50 matches (implementing the \
several ships feature), no more lockups.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ai/smartai.cpp <span style="color: grey">(261cf01)</span></li>
<li>src/ai/ai.h <span style="color: grey">(738c465)</span></li>
<li>src/ai/ai.cpp <span style="color: grey">(384090f)</span></li>
<li>src/ai/dummyai.cpp <span style="color: grey">(15544e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113854/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic