[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117976: Implement support for QFileDialog::setFileMode
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2014-05-03 16:23:09
Message-ID: 20140503162309.16222.54821 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117976/#review57207
-----------------------------------------------------------
src/platformtheme/kdeplatformfiledialoghelper.cpp
<https://git.reviewboard.kde.org/r/117976/#comment39871>
No default?
The Qt docs say that "AnyFile" is the default. \
http://qt-project.org/doc/qt-5/qfiledialog.html#fileMode-prop
So that will result in something like:
case QFileDialogOptions::FileMode::AnyFile:
case default:
m_file....
break;
I like your test! Looks a lot like the one i wrote for the view mode :)
+1 from me after the default case is implemented.
- Mark Gaiser
On May 3, 2014, 3:27 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117976/
> -----------------------------------------------------------
>
> (Updated May 3, 2014, 3:27 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> This implements support for QFileDialog::setFileMode.
> Obsolete value QFileDialog::DirectoryOnly is ignored.
>
> Autotest was added to test all FileModes.
>
>
> Diffs
> -----
>
> autotests/kfiledialog_unittest.cpp 69d474c
> src/platformtheme/kdeplatformfiledialoghelper.h c59bee9
> src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818
>
> Diff: https://git.reviewboard.kde.org/r/117976/diff/
>
>
> Testing
> -------
>
> The file dialog works as expected, autotests pass.
>
>
> Thanks,
>
> David Rosca
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117976/">https://git.reviewboard.kde.org/r/117976/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117976/diff/1/?file=271407#file271407line157" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platformtheme/kdeplatformfiledialoghelper.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">157</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nl">default:</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No default? \
The Qt docs say that "AnyFile" is the default. \
http://qt-project.org/doc/qt-5/qfiledialog.html#fileMode-prop
So that will result in something like:
case QFileDialogOptions::FileMode::AnyFile:
case default:
m_file....
break;</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like your test! Looks \
a lot like the one i wrote for the view mode :) +1 from me after the default case is \
implemented.</pre>
<p>- Mark Gaiser</p>
<br />
<p>On May 3rd, 2014, 3:27 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated May 3, 2014, 3:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This implements support for QFileDialog::setFileMode. Obsolete value \
QFileDialog::DirectoryOnly is ignored.
Autotest was added to test all FileModes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The file dialog works as expected, autotests pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kfiledialog_unittest.cpp <span style="color: \
grey">(69d474c)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: \
grey">(c59bee9)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(777d818)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117976/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic