'Re: Review Request 117976: Implement support for QFileDialog::setFileMode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 117976: Implement support for QFileDialog::setFileMode
From:       "David Rosca" <nowrep () gmail ! com>
Date:       2014-05-03 16:38:10
Message-ID: 20140503163810.31551.59651 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117976/
-----------------------------------------------------------

(Updated May 3, 2014, 4:38 p.m.)

Review request for KDE Frameworks.

Changes
-------

Handle default case in KDEPlatformFileDialog::setFileMode.
Also renamed tests from only testSetMode to testSetFileMode.

Repository: frameworkintegration

Description
-------

This implements support for QFileDialog::setFileMode.
Obsolete value QFileDialog::DirectoryOnly is ignored.

Autotest was added to test all FileModes.

Diffs (updated)
-----

  autotests/kfiledialog_unittest.cpp 69d474c 
  src/platformtheme/kdeplatformfiledialoghelper.h c59bee9 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 

Diff: https://git.reviewboard.kde.org/r/117976/diff/

Testing
-------

The file dialog works as expected, autotests pass.

Thanks,

David Rosca

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117976/">https://git.reviewboard.kde.org/r/117976/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated May 3, 2014, 4:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Handle default case in KDEPlatformFileDialog::setFileMode. Also renamed \
tests from only testSetMode to testSetFileMode.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This implements support for QFileDialog::setFileMode. Obsolete value \
QFileDialog::DirectoryOnly is ignored.

Autotest was added to test all FileModes.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The file dialog works as expected, autotests pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kfiledialog_unittest.cpp <span style="color: \
grey">(69d474c)</span></li>

 <li>src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: \
grey">(c59bee9)</span></li>

 <li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(777d818)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117976/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 