This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/

src/platformtheme/kdeplatformfiledialoghelper.cpp (Diff revision 1)
		157	default:

No default?
The Qt docs say that "AnyFile" is the default. http://qt-project.org/doc/qt-5/qfiledialog.html#fileMode-prop

So that will result in something like:
case QFileDialogOptions::FileMode::AnyFile:
case default:
    m_file....
    break;

I like your test! Looks a lot like the one i wrote for the view mode :)
+1 from me after the default case is implemented.

- Mark Gaiser

On May 3rd, 2014, 3:27 p.m. UTC, David Rosca wrote:

Review request for KDE Frameworks.

By David Rosca.

Updated May 3, 2014, 3:27 p.m.

Repository: frameworkintegration

Description

This implements support for QFileDialog::setFileMode.
Obsolete value QFileDialog::DirectoryOnly is ignored.

Autotest was added to test all FileModes.

Testing

The file dialog works as expected, autotests pass.

Diffs

autotests/kfiledialog_unittest.cpp (69d474c)
src/platformtheme/kdeplatformfiledialoghelper.h (c59bee9)
src/platformtheme/kdeplatformfiledialoghelper.cpp (777d818)

View Diff