'Re: Review Request 117963: Install the English fallback for license translations, simplify the insta'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 117963: Install the English fallback for license translations, simplify the insta
From:       "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date:       2014-05-03 15:47:23
Message-ID: 20140503154723.16222.89422 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/
-----------------------------------------------------------

(Updated May 3, 2014, 5:47 p.m.)

Review request for Documentation and KDE Frameworks.

Repository: kdoctools

Description
-------

This is the combination of two commits:
-- 
Simplify the installation of language-specific files
-- 
Add the English version of license translation file as fallback

When the -translated version of the license file is available,
help:/kdoctools5-common/gpl-translated.html always works even
the translated file for the current language does not exist,
thanks to kio_help's fallback on the English version.

Diffs
-----

  common/CMakeLists.txt cfdcd71 

Diff: https://git.reviewboard.kde.org/r/117963/diff/

Testing
-------

Compiles; the old files from common are still installed; copie of the (translatable) \
licenses are created from the English ones.

Thanks,

Luigi Toscano

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117963/">https://git.reviewboard.kde.org/r/117963/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>

<p style="color: grey;"><i>Updated May 3, 2014, 5:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This is the combination of two commits:
-- 
Simplify the installation of language-specific files
-- 
Add the English version of license translation file as fallback

When the -translated version of the license file is available,
help:/kdoctools5-common/gpl-translated.html always works even
the translated file for the current language does not exist,
thanks to kio_help&#39;s fallback on the English version.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles; the old files from common are still installed; copie of the \
(translatable) licenses are created from the English ones.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>common/CMakeLists.txt <span style="color: grey">(cfdcd71)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117963/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 