[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: [kde-edu]: Review Request: KmPlot - adding functionality to
From: Filipe Saraiva <filip.saraiva () gmail ! com>
Date: 2010-04-25 22:47:15
Message-ID: u2t2c17506a1004251547we8e3eaa1qdc71bf2eca3f0be4 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Please, Anne-Marie or other, commit it.
Thank's.
2010/4/25 Anne-Marie Mahfouf <annma@kde.org>
>
>
> > On 2010-04-17 19:36:30, Tomaz Canabrava wrote:
> > > Looks ok, and is a missing feature for 4.5
> >
> > Filipe Saraiva wrote:
> > Thanks Tomaz.
> >
> > More comments, developers?
>
> Applied the patch, looks OK! Thanks for this patch!
> Do you have a svn account to commit it? If not I'll commit it.
>
> I noticed that Zoom In and Zoom Out are not consistently written that way
> (which was before your patch) so maybe the "zoom-in" and "Zoom in" could be
> changed to "Zoom In" and same with Zoom Out.
>
>
> - Anne-Marie
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3644/#review5090
> -----------------------------------------------------------
>
>
> On 2010-04-17 19:24:32, Filipe Saraiva wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3644/
> > -----------------------------------------------------------
> >
> > (Updated 2010-04-17 19:24:32)
> >
> >
> > Review request for KDE-Edu.
> >
> >
> > Summary
> > -------
> >
> > Adding functionality to change the labels of the coordinates.
> >
> >
> > Diffs
> > -----
> >
> > /trunk/KDE/kdeedu/kmplot/kmplot/editcoords.ui 1112398
> > /trunk/KDE/kdeedu/kmplot/kmplot/kmplot.kcfg 1112398
> > /trunk/KDE/kdeedu/kmplot/kmplot/maindlg.cpp 1112398
> > /trunk/KDE/kdeedu/kmplot/kmplot/settingspagediagram.ui 1112398
> > /trunk/KDE/kdeedu/kmplot/kmplot/settingspagegeneral.ui 1112398
> > /trunk/KDE/kdeedu/kmplot/kmplot/view.cpp 1112398
> >
> > Diff: http://reviewboard.kde.org/r/3644/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Screenshots
> > -----------
> >
> > Menu Change Label Axis
> > http://reviewboard.kde.org/r/3644/s/362/
> > Example of changing the labels of the coordinates
> > http://reviewboard.kde.org/r/3644/s/363/
> > Changes in Diagram System
> > http://reviewboard.kde.org/r/3644/s/364/
> >
> >
> > Thanks,
> >
> > Filipe
> >
> >
>
>
--
Filipe Saraiva
**************************************
Meu blog: http://www.liberdadenafronteira.blogspot.com/
Associação Piauiense de Software Livre
Projeto Software Livre - Piauí - PSL-PI
“Você deve ser a mudança que deseja ver no mundo.” - Gandhi
[Attachment #5 (text/html)]
Please, Anne-Marie or other, commit it.<br>Thank's.<br><br><div \
class="gmail_quote">2010/4/25 Anne-Marie Mahfouf <span dir="ltr"><<a \
href="mailto:annma@kde.org">annma@kde.org</a>></span><br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> <div class="im"><br>
<br>
> On 2010-04-17 19:36:30, Tomaz Canabrava wrote:<br>
</div><div class="im">> > Looks ok, and is a missing feature for 4.5<br>
><br>
</div><div class="im">> Filipe Saraiva wrote:<br>
> Thanks Tomaz.<br>
><br>
> More comments, developers?<br>
<br>
</div>Applied the patch, looks OK! Thanks for this patch!<br>
Do you have a svn account to commit it? If not I'll commit it.<br>
<br>
I noticed that Zoom In and Zoom Out are not consistently written that way (which was \
before your patch) so maybe the "zoom-in" and "Zoom in" could be \
changed to "Zoom In" and same with Zoom Out.<br>
<font color="#888888"><br>
<br>
- Anne-Marie<br>
</font><div class="im"><br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/3644/#review5090" \
target="_blank">http://reviewboard.kde.org/r/3644/#review5090</a><br>
-----------------------------------------------------------<br>
<br>
<br>
</div><div><div></div><div class="h5">On 2010-04-17 19:24:32, Filipe Saraiva \
wrote:<br> ><br>
> -----------------------------------------------------------<br>
> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="http://reviewboard.kde.org/r/3644/" \
target="_blank">http://reviewboard.kde.org/r/3644/</a><br> > \
-----------------------------------------------------------<br> ><br>
> (Updated 2010-04-17 19:24:32)<br>
><br>
><br>
> Review request for KDE-Edu.<br>
><br>
><br>
> Summary<br>
> -------<br>
><br>
> Adding functionality to change the labels of the coordinates.<br>
><br>
><br>
> Diffs<br>
> -----<br>
><br>
> /trunk/KDE/kdeedu/kmplot/kmplot/editcoords.ui 1112398<br>
> /trunk/KDE/kdeedu/kmplot/kmplot/kmplot.kcfg 1112398<br>
> /trunk/KDE/kdeedu/kmplot/kmplot/maindlg.cpp 1112398<br>
> /trunk/KDE/kdeedu/kmplot/kmplot/settingspagediagram.ui 1112398<br>
> /trunk/KDE/kdeedu/kmplot/kmplot/settingspagegeneral.ui 1112398<br>
> /trunk/KDE/kdeedu/kmplot/kmplot/view.cpp 1112398<br>
><br>
> Diff: <a href="http://reviewboard.kde.org/r/3644/diff" \
target="_blank">http://reviewboard.kde.org/r/3644/diff</a><br> ><br>
><br>
> Testing<br>
> -------<br>
><br>
><br>
> Screenshots<br>
> -----------<br>
><br>
> Menu Change Label Axis<br>
> <a href="http://reviewboard.kde.org/r/3644/s/362/" \
target="_blank">http://reviewboard.kde.org/r/3644/s/362/</a><br> > Example of \
changing the labels of the coordinates<br> > <a \
href="http://reviewboard.kde.org/r/3644/s/363/" \
target="_blank">http://reviewboard.kde.org/r/3644/s/363/</a><br> > Changes in \
Diagram System<br> > <a href="http://reviewboard.kde.org/r/3644/s/364/" \
target="_blank">http://reviewboard.kde.org/r/3644/s/364/</a><br> ><br>
><br>
> Thanks,<br>
><br>
> Filipe<br>
><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Filipe \
Saraiva<br>**************************************<br>Meu blog: <a \
href="http://www.liberdadenafronteira.blogspot.com/">http://www.liberdadenafronteira.blogspot.com/</a><br>
<br>Associação Piauiense de Software Livre<br>Projeto Software Livre - Piauí - \
PSL-PI<br><br>“Você deve ser a mudança que deseja ver no mundo.” - Gandhi<br><br>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic