2010/4/25 Anne-Marie Mahfouf <annma@kde.org>

> On 2010-04-17 19:36:30, Tomaz Canabrava wrote:

> > Looks ok, and is a missing feature for 4.5
>

> Filipe Saraiva wrote:
> Thanks Tomaz.
>
> More comments, developers?

Applied the patch, looks OK! Thanks for this patch!
Do you have a svn account to commit it? If not I'll commit it.

I noticed that Zoom In and Zoom Out are not consistently written that way (which was before your patch) so maybe the "zoom-in" and "Zoom in" could be changed to "Zoom In" and same with Zoom Out.

- Anne-Marie

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3644/#review5090
-----------------------------------------------------------

On 2010-04-17 19:24:32, Filipe Saraiva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3644/
> -----------------------------------------------------------
>
> (Updated 2010-04-17 19:24:32)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> Adding functionality to change the labels of the coordinates.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeedu/kmplot/kmplot/editcoords.ui 1112398
> /trunk/KDE/kdeedu/kmplot/kmplot/kmplot.kcfg 1112398
> /trunk/KDE/kdeedu/kmplot/kmplot/maindlg.cpp 1112398
> /trunk/KDE/kdeedu/kmplot/kmplot/settingspagediagram.ui 1112398
> /trunk/KDE/kdeedu/kmplot/kmplot/settingspagegeneral.ui 1112398
> /trunk/KDE/kdeedu/kmplot/kmplot/view.cpp 1112398
>
> Diff: http://reviewboard.kde.org/r/3644/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Menu Change Label Axis
> http://reviewboard.kde.org/r/3644/s/362/
> Example of changing the labels of the coordinates
> http://reviewboard.kde.org/r/3644/s/363/
> Changes in Diagram System
> http://reviewboard.kde.org/r/3644/s/364/
>
>
> Thanks,
>
> Filipe
>
>