--===============0964252355== Content-Type: multipart/alternative; boundary=0016e644c1802696b20485177160 --0016e644c1802696b20485177160 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Please, Anne-Marie or other, commit it. Thank's. 2010/4/25 Anne-Marie Mahfouf > > > > On 2010-04-17 19:36:30, Tomaz Canabrava wrote: > > > Looks ok, and is a missing feature for 4.5 > > > > Filipe Saraiva wrote: > > Thanks Tomaz. > > > > More comments, developers? > > Applied the patch, looks OK! Thanks for this patch! > Do you have a svn account to commit it? If not I'll commit it. > > I noticed that Zoom In and Zoom Out are not consistently written that way > (which was before your patch) so maybe the "zoom-in" and "Zoom in" could = be > changed to "Zoom In" and same with Zoom Out. > > > - Anne-Marie > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3644/#review5090 > ----------------------------------------------------------- > > > On 2010-04-17 19:24:32, Filipe Saraiva wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/3644/ > > ----------------------------------------------------------- > > > > (Updated 2010-04-17 19:24:32) > > > > > > Review request for KDE-Edu. > > > > > > Summary > > ------- > > > > Adding functionality to change the labels of the coordinates. > > > > > > Diffs > > ----- > > > > /trunk/KDE/kdeedu/kmplot/kmplot/editcoords.ui 1112398 > > /trunk/KDE/kdeedu/kmplot/kmplot/kmplot.kcfg 1112398 > > /trunk/KDE/kdeedu/kmplot/kmplot/maindlg.cpp 1112398 > > /trunk/KDE/kdeedu/kmplot/kmplot/settingspagediagram.ui 1112398 > > /trunk/KDE/kdeedu/kmplot/kmplot/settingspagegeneral.ui 1112398 > > /trunk/KDE/kdeedu/kmplot/kmplot/view.cpp 1112398 > > > > Diff: http://reviewboard.kde.org/r/3644/diff > > > > > > Testing > > ------- > > > > > > Screenshots > > ----------- > > > > Menu Change Label Axis > > http://reviewboard.kde.org/r/3644/s/362/ > > Example of changing the labels of the coordinates > > http://reviewboard.kde.org/r/3644/s/363/ > > Changes in Diagram System > > http://reviewboard.kde.org/r/3644/s/364/ > > > > > > Thanks, > > > > Filipe > > > > > > --=20 Filipe Saraiva ************************************** Meu blog: http://www.liberdadenafronteira.blogspot.com/ Associa=E7=E3o Piauiense de Software Livre Projeto Software Livre - Piau=ED - PSL-PI =93Voc=EA deve ser a mudan=E7a que deseja ver no mundo.=94 - Gandhi --0016e644c1802696b20485177160 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Please, Anne-Marie or other, commit it.
Thank's.

2010/4/25 Anne-Marie Mahfouf <annma@kde.org>


> On 2010-04-17 19:36:30, Tomaz Canabrava wrote:
> > Looks ok, and is a missing feature for 4.= 5
>
> Filipe Saraiva wrote:
> =A0 =A0 Thanks Tomaz.
>
> =A0 =A0 More comments, developers?

Applied the patch, looks OK! Thanks for this patch!
Do you have a svn account to commit it? If not I'll commit it.

I noticed that Zoom In and Zoom Out are not consistently written that way (= which was before your patch) so maybe the "zoom-in" and "Zoo= m in" could be changed to "Zoom In" and same with Zoom Out.<= br>

- Anne-Marie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3644/#review5090
-----------------------------------------------------------


On 2010-04-17 19:24:32, Filipe Sara= iva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http:= //reviewboard.kde.org/r/3644/
> -----------------------------------------------------------
>
> (Updated 2010-04-17 19:24:32)
>
>
> Review request for KDE-Edu.
>
>
> Summary
> -------
>
> Adding functionality to change the labels of the coordinates.
>
>
> Diffs
> -----
>
> =A0 /trunk/KDE/kdeedu/kmplot/kmplot/editcoords.ui 1112398
> =A0 /trunk/KDE/kdeedu/kmplot/kmplot/kmplot.kcfg 1112398
> =A0 /trunk/KDE/kdeedu/kmplot/kmplot/maindlg.cpp 1112398
> =A0 /trunk/KDE/kdeedu/kmplot/kmplot/settingspagediagram.ui 1112398
> =A0 /trunk/KDE/kdeedu/kmplot/kmplot/settingspagegeneral.ui 1112398
> =A0 /trunk/KDE/kdeedu/kmplot/kmplot/view.cpp 1112398
>
> Diff: http://reviewboard.kde.org/r/3644/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Menu Change Label Axis
> =A0 http://reviewboard.kde.org/r/3644/s/362/
> Example of changing the labels of the coordinates
> =A0 http://reviewboard.kde.org/r/3644/s/363/
> Changes in Diagram System
> =A0 http://reviewboard.kde.org/r/3644/s/364/
>
>
> Thanks,
>
> Filipe
>
>




--
Filipe Sara= iva
**************************************
Meu blog: http://www.liberdadenafronteira.b= logspot.com/

Associa=E7=E3o Piauiense de Software Livre
Projeto Software Livre - = Piau=ED - PSL-PI

=93Voc=EA deve ser a mudan=E7a que deseja ver no mu= ndo.=94 - Gandhi

--0016e644c1802696b20485177160-- --===============0964252355== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============0964252355==--