[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Konsole private library
From:       Thiago Macieira <thiago () kde ! org>
Date:       2009-02-02 15:31:41
Message-ID: 200902021631.42148.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Em Segunda-feira 02 Fevereiro 2009, ās 13:20:05, Patrick Spendrin escreveu:
> Thiago Macieira schrieb:
> > Patrick Spendrin wrote:
> >> Hi,
> >>
> >> as I am currently porting Konsole to Windows, I need to change the
> >> exports a bit. As this is a rather big change, I'd prefer to get some
> >> more review of the patch here (I already asked in konsole-devel@).
> >>
> >> So please take the time to both take a look at the patch itself and try
> >> to compile & test it.
> >>
> >> If nobody objects, I would commit the patch in the coming days.
> >
> > There's one thing missing in your message and the patch: why?
> >
> > Why is it necessary to have a private library?
>
> Ah, there are two good reasons for it:
> 1) For the konsole part all files get recompiled (at least here) as
> there is a new compile flags set (-DKONSOLE_PART).
> 2) on windows I can't link to the kdeinit_executable as this is no
> library. Until now there are simple KDE_EXPORTs done in the code, which
> do not work here; I want to make the patches work though, so it is
> easiest to use a "private" library as in kmail and some others for that.

Thanks, that makes sense.

The patch looks fine.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Software
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]