From kde-devel  Mon Feb 02 15:31:41 2009
From: Thiago Macieira <thiago () kde ! org>
Date: Mon, 02 Feb 2009 15:31:41 +0000
To: kde-devel
Subject: Re: [PATCH] Konsole private library
Message-Id: <200902021631.42148.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-devel&m=123358877803711
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0969391070=="

--===============0969391070==
Content-Type: multipart/signed;
  boundary="nextPart2798004.gmgpUAR1Cl";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2798004.gmgpUAR1Cl
Content-Type: text/plain;
  charset="iso-8859-1";
  boundary=""
Content-Transfer-Encoding: quoted-printable

Em Segunda-feira 02 Fevereiro 2009, =E0s 13:20:05, Patrick Spendrin escreve=
u:
> Thiago Macieira schrieb:
> > Patrick Spendrin wrote:
> >> Hi,
> >>
> >> as I am currently porting Konsole to Windows, I need to change the
> >> exports a bit. As this is a rather big change, I'd prefer to get some
> >> more review of the patch here (I already asked in konsole-devel@).
> >>
> >> So please take the time to both take a look at the patch itself and try
> >> to compile & test it.
> >>
> >> If nobody objects, I would commit the patch in the coming days.
> >
> > There's one thing missing in your message and the patch: why?
> >
> > Why is it necessary to have a private library?
>
> Ah, there are two good reasons for it:
> 1) For the konsole part all files get recompiled (at least here) as
> there is a new compile flags set (-DKONSOLE_PART).
> 2) on windows I can't link to the kdeinit_executable as this is no
> library. Until now there are simple KDE_EXPORTs done in the code, which
> do not work here; I want to make the patches work though, so it is
> easiest to use a "private" library as in kmail and some others for that.

Thanks, that makes sense.

The patch looks fine.

=2D-=20
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Software
  =A0 =A0 PGP/GPG: 0x6EF45358; fingerprint:
=A0   =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358

--nextPart2798004.gmgpUAR1Cl
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBJhxHeM/XwBW70U1gRAi+XAJ9mkzdp8LjpsbNhV+gaQ/zn0gatsQCguj1+
tgDAuu1Q9hgP9brpSAM3WCk=
=8ba+
-----END PGP SIGNATURE-----

--nextPart2798004.gmgpUAR1Cl--

--===============0969391070==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============0969391070==--