[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Konsole private library
From:       Patrick Spendrin <ps_ml () gmx ! de>
Date:       2009-02-02 12:42:07
Message-ID: 4986EA1F.7060307 () gmx ! de
[Download RAW message or body]

Pau Garcia i Quiles schrieb:
> On Mon, Feb 2, 2009 at 1:20 PM, Patrick Spendrin <ps_ml@gmx.de> wrote:
>> Thiago Macieira schrieb:
>>> Patrick Spendrin wrote:
>>>> Hi,
>>>>
>>>> as I am currently porting Konsole to Windows, I need to change the
>>>> exports a bit. As this is a rather big change, I'd prefer to get some
>>>> more review of the patch here (I already asked in konsole-devel@).
>>>>
>>>> So please take the time to both take a look at the patch itself and try
>>>> to compile & test it.
>>>>
>>>> If nobody objects, I would commit the patch in the coming days.
>>> There's one thing missing in your message and the patch: why?
>>>
>>> Why is it necessary to have a private library?
>> Ah, there are two good reasons for it:
>> 1) For the konsole part all files get recompiled (at least here) as
>> there is a new compile flags set (-DKONSOLE_PART).
>> 2) on windows I can't link to the kdeinit_executable as this is no
>> library. Until now there are simple KDE_EXPORTs done in the code, which
>> do not work here; I want to make the patches work though, so it is
>> easiest to use a "private" library as in kmail and some others for that.
> 
> It is possible to link to an executable:
> http://article.gmane.org/gmane.comp.programming.tools.cmake.user/18735
Yeah but this is slightly different here as konsole is a kdeinit 
executable - meaning on windows you make a static library for it (which 
will not export anything) and then you link that to a stub executable.
Thus it is not possible to link that directly.
> 
> 

regards,
Patrick

-- 
web:                 http://windows.kde.org
mailing list:        kde-windows@kde.org
irc:                 #kde-windows (irc.freenode.net)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]