[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    "Fixed" post-increment operators on iterators
From:       Christian Nitschkowski <segfault_ii () web ! de>
Date:       2004-10-26 20:54:09
Message-ID: 200410262254.13535.segfault_ii () web ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi!
I've read on the dot about the testscripts that check KDEs sources for simple 
errors or bad style.

I took a look at the list of problems on 
http://www.icefox.net/kde/tests/report.html

Then I got a current checkout of kdebase and started to look at the problem 
described here:
http://www.icefox.net/kde/tests/report.html#postincrement

I made two diffs (see attached files).
Did I get this right?
Should I continue this way?

Please CC me in your answer - I'm currently not on the list.

Yours faithfully
Christian Nitschkowski

-- 
--: Christian Nitschkowski <segfault_ii@web.de> :--
--: Jabber: segfault_ii@a-message.de :--
--: ICQ#: 66190597 :--

Go where the silence is and say something
- Chumbawamba

["krdb.diff" (text/x-diff)]

--- krdb.cpp~	2004-10-18 14:58:12.000000000 +0200
+++ krdb.cpp	2004-10-26 22:45:52.665607944 +0200
@@ -456,7 +456,7 @@
       }
     }
 
-    for (QStringList::ConstIterator it = list.begin(); it != list.end(); it++)
+    for (QStringList::ConstIterator it = list.begin(); it != list.end(); ++it)
       copyFile(tmp, locate("appdefaults", *it ), true);
   }
 

["searchwidget.diff" (text/x-diff)]

--- searchwidget.cpp~	2004-10-18 14:58:10.000000000 +0200
+++ searchwidget.cpp	2004-10-26 22:42:51.569138792 +0200
@@ -166,7 +166,7 @@
         matches.append(k->moduleName().stripWhiteSpace());
     }
 
-  for(QStringList::ConstIterator it = matches.begin(); it != matches.end(); it++)
+  for(QStringList::ConstIterator it = matches.begin(); it != matches.end(); ++it)
     _keyList->insertItem(*it);
 
   _keyList->sort();

[Attachment #9 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]