From kde-devel  Tue Oct 26 20:54:09 2004
From: Christian Nitschkowski <segfault_ii () web ! de>
Date: Tue, 26 Oct 2004 20:54:09 +0000
To: kde-devel
Subject: "Fixed" post-increment operators on iterators
Message-Id: <200410262254.13535.segfault_ii () web ! de>
X-MARC-Message: https://marc.info/?l=kde-devel&m=109890898808180
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0832170309=="

--===============0832170309==
Content-Type: multipart/signed;
  boundary="nextPart1359814.efQSXteRIR";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1359814.efQSXteRIR
Content-Type: multipart/mixed;
  boundary="Boundary-01=_xlrfBRwjM54f6hS"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_xlrfBRwjM54f6hS
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi!
I've read on the dot about the testscripts that check KDEs sources for simp=
le=20
errors or bad style.

I took a look at the list of problems on=20
http://www.icefox.net/kde/tests/report.html

Then I got a current checkout of kdebase and started to look at the problem=
=20
described here:
http://www.icefox.net/kde/tests/report.html#postincrement

I made two diffs (see attached files).
Did I get this right?
Should I continue this way?

Please CC me in your answer - I'm currently not on the list.

Yours faithfully
Christian Nitschkowski

=2D-=20
=2D-: Christian Nitschkowski <segfault_ii@web.de> :--
=2D-: Jabber: segfault_ii@a-message.de :--
=2D-: ICQ#: 66190597 :--

Go where the silence is and say something
=2D Chumbawamba

--Boundary-01=_xlrfBRwjM54f6hS
Content-Type: text/x-diff;
  charset="utf-8";
  name="krdb.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="krdb.diff"

=2D-- krdb.cpp~	2004-10-18 14:58:12.000000000 +0200
+++ krdb.cpp	2004-10-26 22:45:52.665607944 +0200
@@ -456,7 +456,7 @@
       }
     }
=20
=2D    for (QStringList::ConstIterator it =3D list.begin(); it !=3D list.en=
d(); it++)
+    for (QStringList::ConstIterator it =3D list.begin(); it !=3D list.end(=
); ++it)
       copyFile(tmp, locate("appdefaults", *it ), true);
   }
=20

--Boundary-01=_xlrfBRwjM54f6hS
Content-Type: text/x-diff;
  charset="utf-8";
  name="searchwidget.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="searchwidget.diff"

=2D-- searchwidget.cpp~	2004-10-18 14:58:10.000000000 +0200
+++ searchwidget.cpp	2004-10-26 22:42:51.569138792 +0200
@@ -166,7 +166,7 @@
         matches.append(k->moduleName().stripWhiteSpace());
     }
=20
=2D  for(QStringList::ConstIterator it =3D matches.begin(); it !=3D matches=
=2Eend(); it++)
+  for(QStringList::ConstIterator it =3D matches.begin(); it !=3D matches.e=
nd(); ++it)
     _keyList->insertItem(*it);
=20
   _keyList->sort();

--Boundary-01=_xlrfBRwjM54f6hS--

--nextPart1359814.efQSXteRIR
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQBBfrl1119BwfrC2gIRAlRYAJ0TzNT1JJvJ5PdhL64D0uuGVWlBHwCdGemb
fRyTwe9lfQ+UgG00xbMZQ48=
=oXq8
-----END PGP SIGNATURE-----

--nextPart1359814.efQSXteRIR--

--===============0832170309==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============0832170309==--