[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kde 3.3 / konqueror / css / font parsing
From:       Esben Mose Hansen <kde () mosehansen ! dk>
Date:       2004-08-31 19:31:57
Message-ID: 200408312131.57846.kde () mosehansen ! dk
[Download RAW message or body]

On Sunday 29 August, 2004 21:24, Thomas Lübking wrote:
> On Saturday 28 August 2004 11:40, Esben Mose Hansen wrote:
> here it is - rather simple patch.
> currently full of explanations and debug messages - as i'm not 100% sure if
> i handled any kind of querky url.

I've had a chance to look it over, and /I/ like it :)

Random points & thought:

ReHandling quirky URLs: That doesn't really matter. It's predictable, and a 
whole lot better than it is now; also, this can't break anything.

>
> But be carefull, it slowdowns the userStyleSheet() function from
> khtml_settings.cpp - this is no problem for khtml (it's only called useless
> once - when reloading the page) but i don't know if other libraries call
> this function.

I think the function does the only sensible thing, namely to recheck for 
appropriate style sheets. For all the function nows, the entire directory 
structure might have changed in the meantime. If called in rapid succession, 
disk caches will ensure reasonable quick response. Besides, local disk 
queries for maybe 10 files (max!) shouldn't take long --- on a local disk. 

Others might want to comment this.

>
> Furthermore it works on all protocols and i changed the local css override
> dir to ~/.userCSS to allow sharing this functionality with other browsers
> (if there's need for it)

I like the handling of protocol --- it's exactly right.
I do not like the ~/.userCSS thing, unless we can point at a standard, and 
even so, we should symlink to/from a ~/.kde/config/... directory structure. 
Otherwise, principle of least surprise would be violated.

> oh, btw:
> do you know how to diff directories without getting those "only in..."
> messages? (couldn't get that out of the manpage)

--new-file or -N: In  directory  comparison,  if a file is found in only one 
directory, treat it as present but empty in the other
              directory.

More random thoughts:

You might want to use kdDebug()... it's easier, at least if you like streams. 
Random example:

kdDebug() << "Hello my " << 5 << " darlings" << endl;

We need a frontend and/or a manual addition. I would not be adverse to write 
either, but let's hear some more thoughts of the code, if any.

It's probably slightly more efficient to append than to prepend string, though 
it depends on QStrings implementation, which I don't know offhand.

Good work! I'll keep the patch in my tree for now. 

A bug should be created or updated with this. The best candidate I found was 
this:
http://bugs.kde.org/show_bug.cgi?id=79930
which is close, but not really.

-- 
regards, Esben
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]