[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Changes to kcron
From:       James Ots <kde () jamesots ! com>
Date:       2004-01-31 1:34:57
Message-ID: 200401310135.03633.kde () jamesots ! com
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 30 January 2004 23:34, Adriaan de Groot wrote:
> My previous commit message was to the effect of "this app needs a serious
> going-over to remove all the string cruftiness and be QString-only".

The problem is that half the app (all the files starting with ct) are not 
dependent on KDE, while the kt... files are, which the original author did so 
that it could be ported to other toolkits more easily.

> A moment of reflection on style: in header files X where you only use
> pointers and references to a particular class, it is faster to declare that
> class as a class (i.e. write "class foo;" in the header file) and then
> #include the requisite header file in the C++ source file. That saves
> including the header file when it is not needed during #inclusion of the
> header file X. It's a small thing.

I think someone mentioned that to me before, but I thought in this case it was 
better to stay with the style of the rest of the app.

In a few days (or perhaps weeks, as I ought to do some paid work as well 
sometime!) I plan to do some more work on kcron as I have a list of other 
enhancements I want to make to it. So I think at that point I'll clean 
everything up as well.

- -- 
Cheers
James Ots
www.jamesots.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAGwZGvipUuB0SBLkRAmIQAKDqBJTgNP4COx2Md18UBAHfBNmM9gCgmgBC
QvQHtXqXNA+zD7VZ1yp2bBE=
=sPpl
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]